Skip to content

[CALCITE-3152] Unify throws in sql parser #1284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 2, 2019
Merged

[CALCITE-3152] Unify throws in sql parser #1284

merged 1 commit into from
Jul 2, 2019

Conversation

danny0405
Copy link
Contributor

Replace generateParseException() and new ParseExecption to
SqlUtil.newContextException, this makes the error message more user
friendly.

@danny0405
[CALCITE-3152] Unify throws in sql parser
6a599a0 
Replace generateParseException() and new ParseExecption to
SqlUtil.newContextException, this makes the error message more user
friendly.
@danny0405 danny0405 requested a review from zhztheplayer July 1, 2019 02:46
@danny0405
Copy link
Contributor Author

@zhztheplayer Can you review this for me ?

@danny0405 danny0405 added the LGTM-will-merge-soon Overall PR looks OK. Only minor things left. label Jul 2, 2019
@danny0405 danny0405 merged commit 65d973b into apache:master Jul 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhztheplayer zhztheplayer Awaiting requested review from zhztheplayer

Assignees
No one assigned
Labels
LGTM-will-merge-soon Overall PR looks OK. Only minor things left.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@danny0405