Skip to content

[CALCITE-3160] Failed to materialize when the aggregate function uses group key #1297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 9, 2019
Merged

[CALCITE-3160] Failed to materialize when the aggregate function uses group key #1297

merged 1 commit into from
Jul 9, 2019

Conversation

DonnyZone
Copy link
Contributor

As illustrated in CALCITE-3160, TrivialRule should conduct the replacement.

hsyuan
hsyuan approved these changes Jul 3, 2019
View reviewed changes
Copy link
Member

@hsyuan hsyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@hsyuan hsyuan added LGTM-will-merge-soon Overall PR looks OK. Only minor things left. returned-with-feedback There are review comments (in JIRA and/or in GitHub) to be implemented before merging the PR and removed LGTM-will-merge-soon Overall PR looks OK. Only minor things left. labels Jul 3, 2019
@DonnyZone DonnyZone changed the title [CALCITE-3160] TrivialRule should conduct replacement when it matches [CALCITE-3160] Failed to materialize when the aggregate function uses group key Jul 4, 2019
@DonnyZone
Copy link
Contributor Author

I change the commit message and PR title back.

@hsyuan hsyuan merged commit 6abf37a into apache:master Jul 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hsyuan hsyuan hsyuan approved these changes

Assignees
No one assigned
Labels
returned-with-feedback There are review comments (in JIRA and/or in GitHub) to be implemented before merging the PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DonnyZone @hsyuan