[CALCITE-3449] Sync tableName logic from TableScan into TableModify #1541
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danny0405
reviewed
Oct 28, 2019
| sqlTargetTable = new SqlIdentifier(qualifiedName, SqlParserPos.ZERO); | ||
| } | ||
|
|
||
| return sqlTargetTable; |
There was a problem hiding this comment.
Thanks, the code looks good, can you add a test case in RelToSqlConverterTest ?
jinxing64
reviewed
Oct 30, 2019
| /** @see #dispatch */ | ||
| public Result visit(TableModify modify) { | ||
| final Map<String, RelDataType> pairs = ImmutableMap.of(); | ||
| final Context context = aliasContext(pairs, false); | ||
|
|
||
| // Target Table Name | ||
| final SqlIdentifier sqlTargetTable = | ||
| new SqlIdentifier(modify.getTable().getQualifiedName(), POS); | ||
| final SqlIdentifier sqlTargetTable = getSqlTargetTable(modify); |
danny0405
changed the title
danny0405
added
no-tests-is-ok
danny0405
pushed a commit
that referenced
this pull request
Nov 1, 2019
…eModify (dy.Zhuang) When sending queries to target databse, sub schemas should be removed from the sql. close #1541
XuQianJin-Stars
pushed a commit
to XuQianJin-Stars/calcite
that referenced
this pull request
Nov 17, 2019
…eModify (dy.Zhuang) When sending queries to target databse, sub schemas should be removed from the sql. close apache#1541
XuQianJin-Stars
pushed a commit
to XuQianJin-Stars/calcite
that referenced
this pull request
Nov 20, 2019
…eModify (dy.Zhuang) When sending queries to target databse, sub schemas should be removed from the sql. close apache#1541
XuQianJin-Stars
pushed a commit
to XuQianJin-Stars/calcite
that referenced
this pull request
Nov 20, 2019
…eModify (dy.Zhuang) When sending queries to target databse, sub schemas should be removed from the sql. close apache#1541
wangxlong
pushed a commit
to wangxlong/calcite
that referenced
this pull request
Feb 13, 2020
…eModify (dy.Zhuang) When sending queries to target databse, sub schemas should be removed from the sql. close apache#1541
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira issue: Jira CALCITE-3449
Fix the bug, modify sql(insert/update/delete) will wrongly have sub-schema before the tablename.