[CALCITE-3604] Fixing locale error message in ExtractValue Function #1666
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ritesh-kapoor
commented
Dec 16, 2019
| @@ -35,6 +37,10 @@ | |||
| */ | |||
| public class SqlXmlFunctionsTest { | |||
|
|
|||
| @BeforeAll public static void setUp() { | |||
There was a problem hiding this comment.
Could not find a better way to fix the test case. Explored LocaleEnUs but no luck
ritesh-kapoor
changed the title
|
Changing the Locale can't fix the issue. |
ritesh-kapoor
changed the title
DonnyZone
reviewed
Dec 18, 2019
| ExInst<CalciteException> illegalBehaviorInExtractValueFunc(String errorBehavior, String value, | ||
| String xpath); | ||
| @BaseMessage("Illegal behavior in EXTRACTVALUE: xml: ''{0}'', xpath expression: ''{1}''") | ||
| ExInst<CalciteException> illegalBehaviorInExtractValueFunc(String xml, String xpath); |
There was a problem hiding this comment.
Since the exception content is not demonstrated, "Illegal behavior" may be confusing to end-uses.
Can we keep the message style same as that of Json function, i.e., "Invalid input for ..."? E.g.,
@BaseMessage("Invalid input for JSON_REMOVE: document: ''{0}'', jsonpath expressions: ''{1}''")
ExInst<CalciteException> invalidInputForJsonRemove(String value, String pathSpecs);
There was a problem hiding this comment.
I have verified this change in my environment, it works well. Thanks!
|
LGTM |
DonnyZone
approved these changes
Dec 19, 2019
danny0405
added
the
LGTM-will-merge-soon
wangxlong
pushed a commit
to wangxlong/calcite
that referenced
this pull request
Feb 13, 2020
* Removing exception from xml function's error messages; * Renaming exception method to invalid input for ExtractValue. close apache#1666
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.