[CALCITE-3637] Update linq4j tests upgrade from junit4 to junit5 #1699
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vlsi
reviewed
Dec 26, 2019
linq4j/src/test/java/org/apache/calcite/linq4j/test/Linq4jSuite.java
Outdated
Show resolved
Hide resolved
XuQianJin-Stars
force-pushed
the
CALCITE-3637
branch
from
6953b43 to
7efb75b
Compare
vlsi
reviewed
Dec 28, 2019
linq4j/src/test/java/org/apache/calcite/linq4j/test/JoinPreserveOrderTest.java
Outdated
Show resolved
Hide resolved
|
Relevant JUnit5 issue is junit-team/junit-framework#878 (which is not solved yet) |
yes, I also looked for tests that did not pass parameters to classes. |
|
Note: it is important that individual cases can be launched from IDE, so please do not rewrite the test into a single "dynamic test" and/or single " |
OK, let me modify it. |
|
hi , @vlsi Thank you very much, When the JUnit5 issue is junit-team/junit5#878 (which is not solved yet) is implemented, I will continue to adjust it once. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As illustrated in CALCITE-3637
Update
linq4jtests upgrade from junit4 to junit5.