Skip to content

[CALCITE-3677] Add assertion to EnumerableTableScan constructor to validate if the table is suitable for enumerable scan #1721

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 9, 2020

Conversation

vlsi
Copy link
Contributor

@vlsi vlsi commented Jan 3, 2020

This is a workaround for CALCITE-3673.
TransientTable can only be implemented with interpreter,
so EnumerableTableScan should not be created for those tables.

@vlsi vlsi force-pushed the table_torel branch 11 times, most recently from 2de4fbf to b297274 Compare January 4, 2020 07:27
@vlsi vlsi changed the title [CALCITE-3673] Skip creating EnumerableTableScan for TransientTable [CALCITE-3677] Add assertion to EnumerableTableScan constructor to validate if the table is suitable for enumerable scan Jan 4, 2020
@vlsi vlsi added the LGTM-will-merge-soon Overall PR looks OK. Only minor things left. label Jan 4, 2020
…lidate if the table is suitable for enumerable scan

This is a workaround for CALCITE-3673.
TransientTable can only be implemented with interpreter,
so EnumerableTableScan should not be created for those tables.
@vlsi vlsi merged commit 2282b95 into apache:master Jan 9, 2020
@vlsi vlsi deleted the table_torel branch January 9, 2020 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
LGTM-will-merge-soon Overall PR looks OK. Only minor things left.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant