Skip to content

[CALCITE-3852] RexSimplify doesn't simplify NOT EQUAL predicates #1854

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 18, 2020
Merged

[CALCITE-3852] RexSimplify doesn't simplify NOT EQUAL predicates #1854

merged 1 commit into from
Mar 18, 2020

Conversation

chunweilei
Copy link
Contributor

No description provided.

kgyrtkirk
kgyrtkirk reviewed Mar 12, 2020
View reviewed changes
@chunweilei chunweilei force-pushed the CALCITE-3852 branch 2 times, most recently from 611fc99 to 7ab36fd Compare March 13, 2020 09:44
hsyuan
hsyuan approved these changes Mar 17, 2020
View reviewed changes
Copy link
Member

@hsyuan hsyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

hsyuan
hsyuan reviewed Mar 17, 2020
View reviewed changes
@hsyuan hsyuan added the LGTM-will-merge-soon Overall PR looks OK. Only minor things left. label Mar 17, 2020
kgyrtkirk
kgyrtkirk reviewed Mar 17, 2020
View reviewed changes
Copy link
Member

@kgyrtkirk kgyrtkirk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry for the late notes @chunweilei ; I didn't got the notification about that you've update the patch...

kgyrtkirk
kgyrtkirk approved these changes Mar 17, 2020
View reviewed changes
Copy link
Member

@kgyrtkirk kgyrtkirk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@chunweilei
Copy link
Contributor Author

Thank you for your review, @kgyrtkirk and @hsyuan .

@chunweilei chunweilei merged commit a8aa439 into apache:master Mar 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hsyuan hsyuan hsyuan approved these changes

@kgyrtkirk kgyrtkirk kgyrtkirk approved these changes

Assignees
No one assigned
Labels
LGTM-will-merge-soon Overall PR looks OK. Only minor things left. slow-tests-needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chunweilei @kgyrtkirk @hsyuan