[CALCITE-3880] Add SortExchange support to RelFieldTrimmer #1879
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kgyrtkirk
reviewed
Mar 30, 2020
kasakrisz
force-pushed
the
CALCITE-3880-master-fieldtrimmer-exchange
branch
from
4b35889 to
9148412
Compare
kgyrtkirk
added
the
LGTM-will-merge-soon
kgyrtkirk
approved these changes
Apr 1, 2020
chunweilei
reviewed
Apr 2, 2020
|
|
||
| System.out.println(Util.toLinux(RelOptUtil.toString(root))); | ||
|
|
||
| RelFieldTrimmer fieldTrimmer = new RelFieldTrimmer(null, builder); |
There was a problem hiding this comment.
No need to print the plan. So I think we'd better remove System.out.println(Util.toLinux(RelOptUtil.toString(root)));.
…ystem.out.println
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request for https://issues.apache.org/jira/browse/CALCITE-3880