[CALCITE-4114] Remove method CalciteAssert.forceDecorrelate (Jiatao Tao) #2073
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aaaaaaron
force-pushed
the
CALCITE-4114
branch
2 times, most recently
from
51441bd to
d6f3646
Compare
Aaaaaaron
changed the title
danny0405
reviewed
Jul 23, 2020
| final RelBuilder b = RelBuilder.create(config); | ||
| pair.right.set(CalcitePrepare.Query.of(relFn.apply(b))); | ||
| }); | ||
| } | ||
|
|
||
| /** Creates a {@link FrameworkConfig} that does not decorrelate. */ | ||
| private FrameworkConfig forceDecorrelate(FrameworkConfig config) { | ||
| private FrameworkConfig withDecorrelate(FrameworkConfig config, boolean needDecorrelate) { | ||
| return Frameworks.newConfigBuilder(config) |
There was a problem hiding this comment.
How about just remove the method and inline the code, the method name is mis-leading.
There was a problem hiding this comment.
How about just remove the method and inline the code, the method name is mis-leading.
👌 agree
There was a problem hiding this comment.
How about just remove the method and inline the code, the method name is mis-leading.
Revised
danny0405
changed the title
|
Please also change the commit message. |
Thanks, revised. |
danny0405
approved these changes
Jul 27, 2020
danny0405
added
the
LGTM-will-merge-soon
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The origin method name is "forceDecorrelate", but what it does actually is not decorrelate, so change it.