[CALCITE-4159] Simplify always-true expressions (such as LIKE '%') to TRUE #2105
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chunweilei
reviewed
Aug 12, 2020
| /** Returns whether this predicate can while simplifying other OR | ||
| * operands. */ | ||
| default boolean allowedInOr(RelOptPredicateList predicates) { | ||
| return true; |
There was a problem hiding this comment.
It seems to lack some words between can and while.
There was a problem hiding this comment.
good catch. i'll fix.
core/src/test/resources/org/apache/calcite/test/SqlToRelConverterTest.xml
Show resolved
Hide resolved
| protected RexNode like(RexNode ref, RexNode pattern, RexNode escape) { | ||
| return rexBuilder.makeCall(SqlStdOperatorTable.LIKE, ref, pattern, escape); | ||
| } | ||
|
|
There was a problem hiding this comment.
What does this method mean? Could you add some comments?
There was a problem hiding this comment.
I disagree. There are lots of surrounding methods with a similar pattern. They are protected methods in a test case. Javadoc would not add anything.
liyafan82
reviewed
Aug 18, 2020
| // is not null. | ||
| RexCall call = (RexCall) e; | ||
| if (call.getOperands().get(1) instanceof RexLiteral) { | ||
| return isEffectivelyNotNull(call.getOperands().get(0)); |
There was a problem hiding this comment.
do we also need to consider cases such as '10 > ref' here?
There was a problem hiding this comment.
I missed this comment. I'll address during CALCITE-4173.
julianhyde
force-pushed
the
4159-simplify
branch
from
016ce74 to
f8fa1f5
Compare
We can now simplify 'a = 1 or a <> 1' to 'true'. To achieve
this, we simplify the second term in a context where we know
'a = 1' is false. This entails a RangeSet inside
simplifyUsingPredicates, so that we can represent <> the same
way that we represent =, > etc. All of the others are a Range,
but <> requires a two-entry RangeSet ('a < 1 or a > 1').
… TRUE RexSimplify needs to recognize that the following expressions can be simplified to TRUE: * c < 0 OR c >= 0 OR c IS NULL * c < 2 OR c > 0 OR c IS NULL * c LIKE '%' OR c IS NULL To enable this fix, we pull 'IS NULL' terms to the front of a list of OR-terms, so that by the time the subsequent terms are reached they know that the term's value is not NULL.
…at represents a set of values or ranges Obsolete use of IN in RexCall.
julianhyde
force-pushed
the
4159-simplify
branch
from
f8fa1f5 to
d1e0a98
Compare
MalteBellmann
pushed a commit
to caespes/calcite
that referenced
this pull request
Feb 21, 2021
… TRUE RexSimplify needs to recognize that the following expressions can be simplified to TRUE: * c < 0 OR c >= 0 OR c IS NULL * c < 2 OR c > 0 OR c IS NULL * c LIKE '%' OR c IS NULL To enable this fix, we pull 'IS NULL' terms to the front of a list of OR-terms, so that by the time the subsequent terms are reached they know that the term's value is not NULL. Close apache#2105
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.