Skip to content

[CALCITE-4312] Improve content of prepareVote draft email #2424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 7, 2021
+5 −16
Merged

[CALCITE-4312] Improve content of prepareVote draft email #2424

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
[CALCITE-4312] Improve content of prepareVote draft email 
1. Remove broken links.
2. Remove docker build instructions (there is no docker-compose file for Calcite).
3. Use GitHub URL to preview release notes.
4. Add subject template.
  • Loading branch information
@zabetak
zabetak committed Jun 4, 2021
commit a333350a0ed2a7c3e9384e6f3add1297bd44a8b5
21 changes: 5 additions & 16 deletions release/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,8 @@ rootProject.configure<ReleaseExtension> {
}

fun ReleaseParams.voteTextGen(): String = """
Subject: [VOTE] Release $componentName $version (release candidate $rc)

Hi all,

I have created a build for $componentName $version, release
Expand All @@ -44,7 +46,7 @@ candidate $rc.
Thanks to everyone who has contributed to this release.

You can read the release notes here:
$previewSiteUri/docs/history.html
https://github.com/apache/calcite/blob/$tag/site/_docs/history.md

The commit to be voted upon:
https://gitbox.apache.org/repos/asf?p=calcite.git;a=commit;h=$gitSha
Expand All @@ -58,15 +60,6 @@ The artifacts to be voted on are located here:
$svnStagingUri
(revision $svnStagingRevision)

RAT report:
$previewSiteUri/rat/rat-report.txt

Site preview is here:
$previewSiteUri/

JavaDoc API preview is here:
$previewSiteUri/api

The hashes of the artifacts are as follows:
${artifacts.joinToString(System.lineSeparator()) { it.sha512 + System.lineSeparator() + "*" + it.name }}

Expand All @@ -77,11 +70,8 @@ Release artifacts are signed with the following key:
https://people.apache.org/keys/committer/$committerId.asc
https://www.apache.org/dist/$tlpUrl/KEYS

To create the jars and test $componentName: "gradle build".

If you do not have a Java/Gradle environment available, you can run
the tests using Docker. To do so, install docker and docker-compose,
then run "docker-compose run test" from the root of the directory.
To create the jars and test $componentName: "gradle build"
(requires an appropriate Gradle/JDK installation)

Please vote on releasing this package as $componentName $version.

Expand All @@ -92,7 +82,6 @@ least three +1 PMC votes are cast.
[ ] 0 I don't feel strongly about it, but I'm okay with the release
[ ] -1 Do not release this package because...


Here is my vote:

+1 (binding)
Expand Down