Skip to content

[CALCITE-4675] Error executing query with SUM and multiplication via JdbcAdapter #2456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 12, 2021
Merged

[CALCITE-4675] Error executing query with SUM and multiplication via JdbcAdapter #2456

merged 1 commit into from
Jul 12, 2021

Conversation

zabetak
Copy link
Member

@zabetak zabetak commented Jul 10, 2021

Use EXPR$ prefix for naming columns when pushing projections
to avoid creating aliases with weird symbols such as '*'.
Such aliases may create problems in some DBMS such as Redshift
when the plan is converted to SQL via RelToSqlConverter.

@zabetak
[CALCITE-4675] Error executing query with SUM and multiplication via …
db0867e 
…JdbcAdapter

Use EXPR$ prefix for naming columns when pushing projections
to avoid creating aliases with weird symbols such as '*'.
Such aliases may create problems in some DBMS such as Redshift
when the plan is converted to SQL via RelToSqlConverter.
@rubenada
Copy link
Contributor

LGTM

NobiGo
NobiGo approved these changes Jul 10, 2021
View reviewed changes
Copy link
Contributor

@NobiGo NobiGo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zabetak zabetak merged commit 4066a34 into apache:master Jul 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NobiGo NobiGo NobiGo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zabetak @rubenada @NobiGo