[CALCITE-5408] Return type of PERCENTILE_CONT should be the same as sort expression #3010
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
libenchao
reviewed
Dec 21, 2022
| @@ -2195,7 +2195,7 @@ public class SqlStdOperatorTable extends ReflectiveSqlOperatorTable { | |||
| */ | |||
| public static final SqlAggFunction PERCENTILE_CONT = | |||
| SqlBasicAggFunction | |||
| .create(SqlKind.PERCENTILE_CONT, ReturnTypes.DOUBLE, | |||
There was a problem hiding this comment.
the comment should also be changed.
There was a problem hiding this comment.
@libenchao Thanks for reviewing, I have resolved it just now.
julianhyde
pushed a commit
to julianhyde/calcite
that referenced
this pull request
Jan 16, 2023
…ort expression Close apache#3010
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Return type of PERCENTILE_CONT should be the same as sort expression