[CALCITE-6220] Rewrite MIN/MAX(BOOLEAN) as BOOL_AND/BOOL_OR for Postgres, Redshift #3646
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tanclary
force-pushed
the
6220-booland
branch
from
905ec7e to
28036af
Compare
tanclary
force-pushed
the
6220-booland
branch
2 times, most recently
from
e6bd8f7 to
d920051
Compare
julianhyde
requested changes
Jan 24, 2024
| @@ -872,6 +872,13 @@ public SqlNode rewriteSingleValueExpr(SqlNode aggCall, RelDataType relDataType) | |||
| return aggCall; | |||
| } | |||
|
|
|||
| /** With x as BOOLEAN column, rewrite MAX(x)/MIN(x) as BOOL_OR(x)/BOOL_AND(x) | |||
There was a problem hiding this comment.
Say what the method does. Nothing to do with BOOLEAN. Declarative "Rewrites" not imperative "rewrite".
| default: | ||
| super.unparseCall(writer, call, leftPrec, rightPrec); | ||
| } | ||
| } | ||
|
|
||
| @Override public SqlNode rewriteMaxMinExpr(SqlNode aggCall, RelDataType relDataType) { |
There was a problem hiding this comment.
Don't instantatiate a dialect. Unnecessary coupling. Use a helper method. E.g. static void unparseFetchUsingLimit().
| + "MIN(\"brand_name\")\n" | ||
| + "FROM \"foodmart\".\"product\""; | ||
| sql(query).ok(expected); | ||
| sql(query).withPostgresql().ok(expectedPostgres); |
There was a problem hiding this comment.
I would chain. And add a test for a 'neutral' dialect:
sql(query).ok(expected)
.withPostgresql().ok(expectedPostgres)
.withRedshift().ok(expectedRedshift)
.withMySQL().ok(expected);
I like how you tested on a non-BOOLEAN column
tanclary
changed the title
tanclary
force-pushed
the
6220-booland
branch
from
fcc104b to
2f2c0ad
Compare
tanclary
force-pushed
the
6220-booland
branch
from
553184f to
6d3302b
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.