[CALCITE-6663] Support SPLIT_PART function for PostgreSql #4027
Conversation
zhuqi-lucas
force-pushed
the
CALCITE-6663
branch
2 times, most recently
from
48434f4 to
a810f9e
Compare
zhuqi-lucas
changed the title
zhuqi-lucas
changed the title
zhuqi-lucas
force-pushed
the
CALCITE-6663
branch
3 times, most recently
from
9c774d8 to
246323a
Compare
select split_part('abc~@def@ghi', '@~', 2); return nothing in PG. There is a typographical error here. |
core/src/main/java/org/apache/calcite/runtime/SqlFunctions.java
Outdated
Show resolved
Hide resolved
core/src/main/java/org/apache/calcite/runtime/SqlFunctions.java
Outdated
Show resolved
Hide resolved
testkit/src/main/java/org/apache/calcite/test/SqlOperatorTest.java
Outdated
Show resolved
Hide resolved
testkit/src/main/java/org/apache/calcite/test/SqlOperatorTest.java
Outdated
Show resolved
Hide resolved
| false); | ||
| final SqlOperatorFixture f = f0.withLibrary(SqlLibrary.POSTGRESQL); | ||
|
|
||
| f.checkScalar("SPLIT_PART('abc~@~def~@~ghi', '~@~', 2)", "def", "VARCHAR(15) NOT NULL"); |
There was a problem hiding this comment.
Do we should return VARCHAR(15) for this function? I want to confirm is there a document explaining？
There was a problem hiding this comment.
This type comes from ARG0_NULLABLE.
It is true that the result will never be larger.
Another reasonable type would be VARCHAR.
I think there are many functions which use this result type inference.
But indeed, the VARCHAR(N) types have some unintuitive behaviors sometimes.
There was a problem hiding this comment.
Changed to VARCHAR , addressed in latest PR, thanks!
testkit/src/main/java/org/apache/calcite/test/SqlOperatorTest.java
Outdated
Show resolved
Hide resolved
Updated, thanks! |
core/src/main/java/org/apache/calcite/runtime/SqlFunctions.java
Outdated
Show resolved
Hide resolved
core/src/main/java/org/apache/calcite/runtime/SqlFunctions.java
Outdated
Show resolved
Hide resolved
testkit/src/main/java/org/apache/calcite/test/SqlOperatorTest.java
Outdated
Show resolved
Hide resolved
|
This has already two approvals, Can you please sqash the commits to a single one, which should have the same title as the JIRA issue? Then we can merge the PR. Thank you. |
zhuqi-lucas
force-pushed
the
CALCITE-6663
branch
from
5a1421b to
08f361f
Compare
Done, thanks @mihaibudiu ! |
| @@ -10901,6 +10901,36 @@ void checkEndsWith(SqlOperatorFixture f0, FunctionAlias functionAlias) { | |||
| + "requires extra delimiter argument", false); | |||
| } | |||
|
|
|||
| /** Tests the {@code SPLIT_PART} operator. */ | |||
There was a problem hiding this comment.
Added now, thanks!
zhuqi-lucas
force-pushed
the
CALCITE-6663
branch
from
08f361f to
982ed8d
Compare
|
|
Will merge this after the CI completes |
We can support split_part function for postgresq:
split_part ( string text, delimiter text, n integer ) → text
Splits string at occurrences of delimiter and returns the n'th field (counting from one), or when n is negative, returns the |n|'th-from-last field.