[CALCITE-6813] UNNEST infers incorrect nullability for the result ... #4179
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n applied to an array that contains nullable ROW values Signed-off-by: Mihai Budiu <[email protected]>
ILuffZhe
reviewed
Feb 5, 2025
| + " (values (ARRAY[ROW(1, 'Alice'), ROW(2, NULL), ROW(NULL, 'Bob'), NULL]))\n" | ||
| + "select e.EXPR$0\n" | ||
| + "from orders, UNNEST(orders.data) as e") | ||
| .type(actualType -> { |
There was a problem hiding this comment.
What if all ROW values are not nullable?
There was a problem hiding this comment.
I assume you mean: "none of the values in any ROW is null."
That case was covered before. ROWs with null values were not handled correctly.
ILuffZhe
approved these changes
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when applied to an array that contains nullable ROW values