[CALCITE-7006] Incorrect left join results with IS NOT DISTINCT FROM under specific plan #4368
Conversation
| @@ -854,4 +854,154 @@ EnumerableCalc(expr#0..1=[{inputs}], A=[$t0]) | |||
| EnumerableValues(tuples=[[{ 1 }, { null }]]) | |||
| !plan | |||
|
|
|||
| # Test for Double | |||
| SELECT t1.a | |||
There was a problem hiding this comment.
I think these are DECIMAL.
For DOUBLE you have to write 1.0e0
There was a problem hiding this comment.
the test is good, but add a DOUBLE test too
In general, joining on double is tricky, but for this case it should work fine
There was a problem hiding this comment.
the test for DECIMAL was good too, but it's also covered by the ARRAY tests below
core/src/test/resources/sql/join.iq
Outdated
|
|
||
| !ok | ||
|
|
||
| # Test for TimesStamp |
|
|
||
| !ok | ||
|
|
||
| # Test for Decimal |
There was a problem hiding this comment.
were these tests failing previously?
mihaibudiu
added
the
LGTM-will-merge-soon
|
@mihaibudiu I have fixed the comment above. |
|
I will merge this once CI passes; it's a serious bug. Surprising it wasn't found earlier. |
Please wait for me to squish these commits. The reason is that previously it was |
…under specific plan
|
JIRA link: CALCITE-7006