Skip to content

[SPARK-37968][BUILD][CORE] Upgrade commons-collections 3.x to commons-collections4 #35257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

LuciferYang
Copy link
Contributor

@LuciferYang LuciferYang commented Jan 20, 2022

What changes were proposed in this pull request?

Apache commons-collections 3.x is a Java 1.3 compatible version, and it does not use Java 5 generics. Apache commons-collections4 4.4 is an upgraded version of commons-collections and it built by Java 8.

So this pr upgraded this dependency and fixed the code that block compilation due to this upgrade.

Why are the changes needed?

Dependency upgrade, the release notes as follows:

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Pass GA

@@ -38,6 +38,7 @@ commons-beanutils/1.9.4//commons-beanutils-1.9.4.jar
commons-cli/1.5.0//commons-cli-1.5.0.jar
commons-codec/1.15//commons-codec-1.15.jar
commons-collections/3.2.2//commons-collections-3.2.2.jar
Copy link
Contributor Author

@LuciferYang LuciferYang Jan 20, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hadoop-2.7 profile still need commons-collections 3.2.2 due to It is the compilation dependency of hadoop-2.7.

Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM.
I also checked that there is no other place to use this.

$ git grep 'org.apache.commons.collections'
core/src/main/scala/org/apache/spark/broadcast/BroadcastManager.scala:import org.apache.commons.collections.map.{AbstractReferenceMap, ReferenceMap}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants