[Catalog] Remove Multidex #4637
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MGaetan89
force-pushed
the
remove_multidex
branch
from
f1fefa8 to
07d8aac
Compare
drchen
approved these changes
Mar 5, 2025
drchen
added
the
Reviewing Internally
MGaetan89
force-pushed
the
remove_multidex
branch
from
07d8aac to
a76b97d
Compare
Contributor
Author
|
I've updated the PR to fix the conflicts caused by 4662301 |
MGaetan89
force-pushed
the
remove_multidex
branch
2 times, most recently
from
3816e0d to
bcc2343
Compare
Contributor
Author
|
@drchen any progress on the internal review? |
MGaetan89
force-pushed
the
remove_multidex
branch
from
bcc2343 to
da602f1
Compare
MGaetan89
force-pushed
the
remove_multidex
branch
from
da602f1 to
09b61e3
Compare
Contributor
Author
|
I've updated the PR to fix the conflict |
With the minSdk being 21 now, Multidex is not needed anymore. See https://developer.android.com/build/multidex#mdex-on-l
MGaetan89
force-pushed
the
remove_multidex
branch
from
2afd7cf to
109d5fb
Compare
Contributor
Author
|
@drchen I've updated the PR to fix the conflicts |
Contributor
Author
|
@drchen any update here? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the minSdk being 21 now, Multidex is not needed anymore.
See https://developer.android.com/build/multidex#mdex-on-l
I've also removed some unnecessary SDK version checks. Let me know if these should be in a dedicated PR.