-
Notifications
You must be signed in to change notification settings - Fork 22.8k
CSS modules: separate out unsupported features #40576
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are missing:
- https://developer.mozilla.org/en-US/docs/Web/CSS/image-resolution
- https://developer.mozilla.org/en-US/docs/Web/CSS/line-height-step
I think we should have a uniform template for noting non-support in module landing pages and other pages, and apply it to all other existing notes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@estelle a few bits for you to consider, but nothing major. Nice work.
- : Descriptor: | ||
- {{cssxref("@font-feature-values/font-display", "font-display")}} | ||
|
||
The specification also defines the {{cssxref("@font-feature-values/font-display", "font-display")}} descriptor which is not yet supported by any browser. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The specification also defines the {{cssxref("@font-feature-values/font-display", "font-display")}} descriptor which is not yet supported by any browser. | |
The specification also defines the {{cssxref("@font-feature-values/font-display", "font-display")}} descriptor, which is not yet supported by any browser. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, I'd think about how this section is rendered and try to make it easier to follow. The "At-rule..." line that precedes this line is bulleted, but the other "At-rule..." lines aren't.
And the "The specification also defines..." paragraphs aren't indented, which makes it hard to figure out which At-rule section they relate to. Would it be easier to follow if you made the "At-rule..." lines into sub-headings, and/or made the "The specification also defines..." paragraphs into notes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I changed all the pages to make them uniform. Basically:
The X module also introduces Y. Currently, no browsers support this/these feature(s).
it is possible that they are implemented behind a flag, so didn't want to use that lingo (pedantic).
@@ -36,13 +36,14 @@ While masking provides more control and options, clipping can perform better if | |||
- {{cssxref("mask-size")}} | |||
- {{cssxref("mask-type")}} | |||
- {{cssxref("mask-border")}} shorthand | |||
- {{cssxref("mask-border-mode")}} | |||
- {{cssxref("mask-border-outset")}} | |||
- {{cssxref("mask-border-repeat")}} | |||
- {{cssxref("mask-border-slice")}} | |||
- {{cssxref("mask-border-source")}} | |||
- {{cssxref("mask-border-width")}} | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove blank line?
- `~` ([Subsequent sibling combinator](/en-US/docs/Web/CSS/Subsequent-sibling_combinator)) | ||
- " " ([Descendant combinator](/en-US/docs/Web/CSS/Descendant_combinator)) | ||
- `|` ([Namespace separator](/en-US/docs/Web/CSS/Namespace_separator)) | ||
- `,` ([Selector list](/en-US/docs/Web/CSS/Selector_list)) | ||
|
||
> [!NOTE] | ||
> The CSS selectors module introduces the [column combinator](/en-US/docs/Web/CSS/Column_combinator) (`||`) that has not yet been implemented. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
> The CSS selectors module introduces the [column combinator](/en-US/docs/Web/CSS/Column_combinator) (`||`) that has not yet been implemented. | |
> The CSS selectors module introduces the [column combinator](/en-US/docs/Web/CSS/Column_combinator) (`||`), which is not yet supported by any browser. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To make it consistent with the previous similar notes in the CSS fonts module page?
Also, this is a note, and they aren't. I think having them all as notes is a good idea.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They should definitely be consistent. Notes are to alert people to things, and stuff that is written but not implemented is more of an aside. i am going to de-note them in the module landing pages.
@@ -98,6 +96,9 @@ Selectors, whether used in CSS or JavaScript, enable targeting HTML elements bas | |||
- [Type selectors](/en-US/docs/Web/CSS/Type_selectors) | |||
- [Universal selectors](/en-US/docs/Web/CSS/Universal_selectors) | |||
|
|||
> [!NOTE] | |||
> The CSS selectors module introduces the {{CSSXref(":blank")}}, {{CSSXref(":current")}}, {{CSSXref(":local-link")}}, and {{CSSXref(":target-within")}} pseudo-classes, which have not yet been implemented. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
> The CSS selectors module introduces the {{CSSXref(":blank")}}, {{CSSXref(":current")}}, {{CSSXref(":local-link")}}, and {{CSSXref(":target-within")}} pseudo-classes, which have not yet been implemented. | |
> The CSS selectors module introduces the {{CSSXref(":blank")}}, {{CSSXref(":current")}}, {{CSSXref(":local-link")}}, and {{CSSXref(":target-within")}} pseudo-classes, which are not yet supported by any browser. |
Again, for consistency with previous notes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
agree. Going with "support" instead of "implement" for pedantic reasons.
@@ -49,7 +49,7 @@ Every CSS declaration consists of a property/value pair. The value can take vari | |||
- {{cssxref("tan()")}} | |||
- {{cssxref("url_function", "url()")}} | |||
|
|||
Additional functions, including `calc-mix()`, `crossorigin()`, `first-valid()`, `if()`, `integrity()`, `progress()`, `random()`, `random-item()`, `referrerpolicy()`, `src()`, `type()`, and `toggle()`, are defined in the specifications, but not yet implemented in browsers. | |||
The CSS values and units module introduces the `calc-mix()`, `crossorigin()`, `first-valid()`, `integrity()`, `progress()`, `random()`, `random-item()`, `referrerpolicy()`, `src()`, `type()`, and `toggle()` functions, which are not yet supported in any browser. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
note?
@@ -86,6 +84,8 @@ Additional functions, including `calc-mix()`, `crossorigin()`, `first-valid()`, | |||
- [`<url-modifier>`](/en-US/docs/Web/CSS/url_function#url-modifier) | |||
- [`<view-timeline-name>`](/en-US/docs/Web/CSS/view-timeline-name) | |||
|
|||
The CSS values and units module introduces the [`<frequency>`](/en-US/docs/Web/CSS/frequency) and [`<frequency-percentage>`](/en-US/docs/Web/CSS/frequency-percentage) data types, which are not yet supported in any browser. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
note?
@@ -62,7 +62,7 @@ Where a `<frequency-percentage>` is specified as an allowable type, this means t | |||
|
|||
## Browser compatibility | |||
|
|||
No browser currently supports this feature. | |||
Currently, no browsers support this feature. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently, no browsers support this feature. | |
Currently, no browsers have implemented this feature. |
for consistency with previous such notes?
@@ -48,7 +48,7 @@ Invalid frequency values: | |||
|
|||
## Browser compatibility | |||
|
|||
No browser currently supports this feature. | |||
Currently, no browsers support this feature. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently, no browsers support this feature. | |
Currently, no browsers have implemented this feature. |
for consistency with previous such notes?
@@ -159,7 +159,7 @@ The above will put a semi-transparent black mask over the Firefox logo backgroun | |||
|
|||
## Browser compatibility | |||
|
|||
There is no browser implementing this feature. | |||
Currently, no browsers support this feature. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently, no browsers support this feature. | |
Currently, no browsers have implemented this feature. |
for consistency with previous such notes?
@@ -44,7 +44,7 @@ mask-border-mode: unset; | |||
|
|||
## Browser compatibility | |||
|
|||
This property is not supported by any browser yet. | |||
+Currently, no browsers have implemented this property. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+Currently, no browsers have implemented this property. | |
Currently, no browsers have implemented this feature. |
for consistency with previous such notes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
agreed. going with "feature" in all cases, for consistency and findability
line-height-step is in a spec that has not been implemented and that we haven't documented. I added a link to the spec in the see also to help my future self find the spec and document the module. We may want to delete that page (but not in this PR). Fixed image-resolution. thanks for finding that one. |
I made everything uniform, so touched almost all the content. It may be easier to re-review rather than check previous comments individually. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@estelle Very nice! Just a couple more suggestions for consistency, but approving.
Yeah, that's what I did, so all good. |
Co-authored-by: Chris Mills <[email protected]>
Co-authored-by: Chris Mills <[email protected]>
took a look at documented features that have no support