Skip to content

CSS modules: separate out unsupported features #40576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Aug 4, 2025
Merged

CSS modules: separate out unsupported features #40576

merged 10 commits into from
Aug 4, 2025

Conversation

estelle
Copy link
Member

@estelle estelle commented Jul 31, 2025

took a look at documented features that have no support

@estelle estelle requested a review from a team as a code owner July 31, 2025 00:07
@estelle estelle requested review from chrisdavidmills and removed request for a team July 31, 2025 00:07
@github-actions github-actions bot added Content:CSS Cascading Style Sheets docs size/m [PR only] 51-500 LoC changed labels Jul 31, 2025
Copy link
Contributor

github-actions bot commented Jul 31, 2025

Preview URLs (33 pages)
Flaws (6)

Note! 29 documents with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Web/CSS/@color-profile
Title: @color-profile
Flaw count: 1

  • broken_links:
    • Can't resolve /en-US/docs/Web/CSS/declaration-list

URL: /en-US/docs/Web/CSS/CSS_conditional_rules
Title: CSS conditional rules
Flaw count: 1

  • macros:
    • Macro produces link /en-US/docs/Web/CSS/at-rule which is a redirect

URL: /en-US/docs/Web/CSS/CSS_masking
Title: CSS masking
Flaw count: 1

  • macros:
    • Macro produces link /en-US/docs/Web/CSS/url which is a redirect

URL: /en-US/docs/Web/CSS/image/image
Title: image()
Flaw count: 3

  • broken_links:
    • Can't resolve /en-US/docs/Web/CSS/url-modifier
    • Can't resolve /en-US/docs/Web/CSS/url-token
    • Can't resolve /en-US/docs/Web/CSS/url-modifier
External URLs (1)

URL: /en-US/docs/Web/CSS/line-height-step
Title: line-height-step

(comment last updated: 2025-08-04 11:45:21)

Copy link
Member

@Josh-Cena Josh-Cena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are missing:

I think we should have a uniform template for noting non-support in module landing pages and other pages, and apply it to all other existing notes

Copy link
Contributor

@chrisdavidmills chrisdavidmills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@estelle a few bits for you to consider, but nothing major. Nice work.

- : Descriptor:
- {{cssxref("@font-feature-values/font-display", "font-display")}}

The specification also defines the {{cssxref("@font-feature-values/font-display", "font-display")}} descriptor which is not yet supported by any browser.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The specification also defines the {{cssxref("@font-feature-values/font-display", "font-display")}} descriptor which is not yet supported by any browser.
The specification also defines the {{cssxref("@font-feature-values/font-display", "font-display")}} descriptor, which is not yet supported by any browser.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, I'd think about how this section is rendered and try to make it easier to follow. The "At-rule..." line that precedes this line is bulleted, but the other "At-rule..." lines aren't.

And the "The specification also defines..." paragraphs aren't indented, which makes it hard to figure out which At-rule section they relate to. Would it be easier to follow if you made the "At-rule..." lines into sub-headings, and/or made the "The specification also defines..." paragraphs into notes?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed all the pages to make them uniform. Basically:

The X module also introduces Y. Currently, no browsers support this/these feature(s).

it is possible that they are implemented behind a flag, so didn't want to use that lingo (pedantic).

@@ -36,13 +36,14 @@ While masking provides more control and options, clipping can perform better if
- {{cssxref("mask-size")}}
- {{cssxref("mask-type")}}
- {{cssxref("mask-border")}} shorthand
- {{cssxref("mask-border-mode")}}
- {{cssxref("mask-border-outset")}}
- {{cssxref("mask-border-repeat")}}
- {{cssxref("mask-border-slice")}}
- {{cssxref("mask-border-source")}}
- {{cssxref("mask-border-width")}}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove blank line?

- `~` ([Subsequent sibling combinator](/en-US/docs/Web/CSS/Subsequent-sibling_combinator))
- " " ([Descendant combinator](/en-US/docs/Web/CSS/Descendant_combinator))
- `|` ([Namespace separator](/en-US/docs/Web/CSS/Namespace_separator))
- `,` ([Selector list](/en-US/docs/Web/CSS/Selector_list))

> [!NOTE]
> The CSS selectors module introduces the [column combinator](/en-US/docs/Web/CSS/Column_combinator) (`||`) that has not yet been implemented.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
> The CSS selectors module introduces the [column combinator](/en-US/docs/Web/CSS/Column_combinator) (`||`) that has not yet been implemented.
> The CSS selectors module introduces the [column combinator](/en-US/docs/Web/CSS/Column_combinator) (`||`), which is not yet supported by any browser.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To make it consistent with the previous similar notes in the CSS fonts module page?

Also, this is a note, and they aren't. I think having them all as notes is a good idea.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They should definitely be consistent. Notes are to alert people to things, and stuff that is written but not implemented is more of an aside. i am going to de-note them in the module landing pages.

@@ -98,6 +96,9 @@ Selectors, whether used in CSS or JavaScript, enable targeting HTML elements bas
- [Type selectors](/en-US/docs/Web/CSS/Type_selectors)
- [Universal selectors](/en-US/docs/Web/CSS/Universal_selectors)

> [!NOTE]
> The CSS selectors module introduces the {{CSSXref(":blank")}}, {{CSSXref(":current")}}, {{CSSXref(":local-link")}}, and {{CSSXref(":target-within")}} pseudo-classes, which have not yet been implemented.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
> The CSS selectors module introduces the {{CSSXref(":blank")}}, {{CSSXref(":current")}}, {{CSSXref(":local-link")}}, and {{CSSXref(":target-within")}} pseudo-classes, which have not yet been implemented.
> The CSS selectors module introduces the {{CSSXref(":blank")}}, {{CSSXref(":current")}}, {{CSSXref(":local-link")}}, and {{CSSXref(":target-within")}} pseudo-classes, which are not yet supported by any browser.

Again, for consistency with previous notes?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agree. Going with "support" instead of "implement" for pedantic reasons.

@@ -49,7 +49,7 @@ Every CSS declaration consists of a property/value pair. The value can take vari
- {{cssxref("tan()")}}
- {{cssxref("url_function", "url()")}}

Additional functions, including `calc-mix()`, `crossorigin()`, `first-valid()`, `if()`, `integrity()`, `progress()`, `random()`, `random-item()`, `referrerpolicy()`, `src()`, `type()`, and `toggle()`, are defined in the specifications, but not yet implemented in browsers.
The CSS values and units module introduces the `calc-mix()`, `crossorigin()`, `first-valid()`, `integrity()`, `progress()`, `random()`, `random-item()`, `referrerpolicy()`, `src()`, `type()`, and `toggle()` functions, which are not yet supported in any browser.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note?

@@ -86,6 +84,8 @@ Additional functions, including `calc-mix()`, `crossorigin()`, `first-valid()`,
- [`<url-modifier>`](/en-US/docs/Web/CSS/url_function#url-modifier)
- [`<view-timeline-name>`](/en-US/docs/Web/CSS/view-timeline-name)

The CSS values and units module introduces the [`<frequency>`](/en-US/docs/Web/CSS/frequency) and [`<frequency-percentage>`](/en-US/docs/Web/CSS/frequency-percentage) data types, which are not yet supported in any browser.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note?

@@ -62,7 +62,7 @@ Where a `<frequency-percentage>` is specified as an allowable type, this means t

## Browser compatibility

No browser currently supports this feature.
Currently, no browsers support this feature.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Currently, no browsers support this feature.
Currently, no browsers have implemented this feature.

for consistency with previous such notes?

@@ -48,7 +48,7 @@ Invalid frequency values:

## Browser compatibility

No browser currently supports this feature.
Currently, no browsers support this feature.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Currently, no browsers support this feature.
Currently, no browsers have implemented this feature.

for consistency with previous such notes?

@@ -159,7 +159,7 @@ The above will put a semi-transparent black mask over the Firefox logo backgroun

## Browser compatibility

There is no browser implementing this feature.
Currently, no browsers support this feature.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Currently, no browsers support this feature.
Currently, no browsers have implemented this feature.

for consistency with previous such notes?

@@ -44,7 +44,7 @@ mask-border-mode: unset;

## Browser compatibility

This property is not supported by any browser yet.
+Currently, no browsers have implemented this property.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
+Currently, no browsers have implemented this property.
Currently, no browsers have implemented this feature.

for consistency with previous such notes?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agreed. going with "feature" in all cases, for consistency and findability

@estelle
Copy link
Member Author

estelle commented Aug 4, 2025

You are missing:

I think we should have a uniform template for noting non-support in module landing pages and other pages, and apply it to all other existing notes

line-height-step is in a spec that has not been implemented and that we haven't documented. I added a link to the spec in the see also to help my future self find the spec and document the module. We may want to delete that page (but not in this PR).

Fixed image-resolution. thanks for finding that one.

@estelle
Copy link
Member Author

estelle commented Aug 4, 2025

@estelle a few bits for you to consider, but nothing major. Nice work.

I made everything uniform, so touched almost all the content. It may be easier to re-review rather than check previous comments individually.

Copy link
Contributor

@chrisdavidmills chrisdavidmills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@estelle Very nice! Just a couple more suggestions for consistency, but approving.

@chrisdavidmills
Copy link
Contributor

@estelle a few bits for you to consider, but nothing major. Nice work.

I made everything uniform, so touched almost all the content. It may be easier to re-review rather than check previous comments individually.

Yeah, that's what I did, so all good.

@estelle estelle merged commit bc761c1 into main Aug 4, 2025
12 checks passed
@estelle estelle deleted the 226 branch August 4, 2025 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:CSS Cascading Style Sheets docs size/m [PR only] 51-500 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants