Skip to content

Lint: identifiers should use kebab-case #40603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 5, 2025
Merged

Lint: identifiers should use kebab-case #40603

merged 2 commits into from
Aug 5, 2025

Conversation

Josh-Cena
Copy link
Member

After #40228, we are a lot more explicit on some CSS stylistic decisions. This PR makes sure that all CSS identifiers use kebab-case, while SVG value keywords use camelCase (mostly currentColor).

@Josh-Cena Josh-Cena requested review from a team as code owners August 3, 2025 06:58
@Josh-Cena Josh-Cena requested review from fred-wang, estelle, wbamberg and dipikabh and removed request for a team August 3, 2025 06:58
@github-actions github-actions bot added Content:CSS Cascading Style Sheets docs Content:HTML Hypertext Markup Language docs Content:WebAPI Web API docs Content:Learn Learning area docs Content:Accessibility Accessibility docs Content:SVG SVG docs Content:MathML MathML docs Content:Glossary Glossary entries Content:Firefox Content in the Mozilla/Firefox subtree labels Aug 3, 2025
@Josh-Cena Josh-Cena removed request for a team, fred-wang, estelle and wbamberg August 3, 2025 06:58
@Josh-Cena Josh-Cena requested review from bsmth and a team and removed request for a team August 3, 2025 06:58
@github-actions github-actions bot added the size/l [PR only] 501-1000 LoC changed label Aug 3, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 3, 2025 •
edited
Loading

Preview URLs (119 pages)
Flaws (42)

Note! 89 documents with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Web/API/CSS_Painting_API
Title: CSS Painting API
Flaw count: 1

  • unknown:
    • Error opening /home/runner/work/content/content/files/en-us/web/api/css_painting_api/Guide/boxbg.png: No such file or directory (os error 2)

URL: /en-US/docs/Web/CSS/@font-face/ascent-override
Title: ascent-override
Flaw count: 1

  • broken_links:
    • /en-US/docs/Web/CSS/At-rule is a redirect

URL: /en-US/docs/Web/CSS/@font-face/descent-override
Title: descent-override
Flaw count: 1

  • broken_links:
    • /en-US/docs/Web/CSS/At-rule is a redirect

URL: /en-US/docs/Web/CSS/@font-face/line-gap-override
Title: line-gap-override
Flaw count: 1

  • broken_links:
    • /en-US/docs/Web/CSS/At-rule is a redirect

URL: /en-US/docs/Web/CSS/@font-face/size-adjust
Title: size-adjust
Flaw count: 1

  • broken_links:
    • /en-US/docs/Web/CSS/At-rule is a redirect

URL: /en-US/docs/Web/CSS/@font-face/src
Title: src
Flaw count: 5

  • broken_links:
    • /en-US/docs/Web/CSS/At-rule is a redirect
    • Can't resolve /en-US/docs/Web/CSS/font-src-list
    • Can't resolve /en-US/docs/Web/CSS/url-modifier
    • Can't resolve /en-US/docs/Web/CSS/url-token
    • Can't resolve /en-US/docs/Web/CSS/url-modifier

URL: /en-US/docs/Web/CSS/@font-palette-values/font-family
Title: font-family
Flaw count: 3

  • broken_links:
    • /en-US/docs/Web/CSS/At-rule is a redirect
  • macros:
    • Macro produces link /en-US/docs/Web/CSS/@font-palette-values/ which is a redirect
    • Macro produces link /en-US/docs/Web/CSS/font-palette/ which is a redirect

URL: /en-US/docs/Web/CSS/@position-try
Title: @position-try
Flaw count: 1

  • broken_links:
    • Can't resolve /en-US/docs/Web/CSS/declaration-list

URL: /en-US/docs/Web/CSS/animation-range
Title: animation-range
Flaw count: 2

  • broken_links:
    • Can't resolve /en-US/docs/Web/CSS/timeline-range-name
    • Can't resolve /en-US/docs/Web/CSS/timeline-range-name

URL: /en-US/docs/Web/CSS/animation-range-end
Title: animation-range-end
Flaw count: 1

  • broken_links:
    • Can't resolve /en-US/docs/Web/CSS/timeline-range-name

URL: /en-US/docs/Web/CSS/animation-range-start
Title: animation-range-start
Flaw count: 1

  • broken_links:
    • Can't resolve /en-US/docs/Web/CSS/timeline-range-name

URL: /en-US/docs/Web/CSS/block-size
Title: block-size
Flaw count: 1

  • broken_links:
    • Can't resolve /en-US/docs/Web/CSS/size-keyword

URL: /en-US/docs/Web/CSS/calc
Title: calc()
Flaw count: 1

  • macros:
    • Macro produces link /en-US/docs/Web/CSS/auto which is a redirect

URL: /en-US/docs/Web/CSS/CSS_anchor_positioning/Using
Title: Using CSS anchor positioning
Flaw count: 1

  • unknown:
    • Error parsing /shared-assets/images/diagrams/css/anchor-positioning/position-area.svg: No such file or directory (os error 2)

URL: /en-US/docs/Web/CSS/CSS_overflow/CSS_carousels
Title: Creating CSS carousels
Flaw count: 1

  • unknown:
    • Error parsing /shared-assets/images/diagrams/css/carousels/carousel.svg: No such file or directory (os error 2)

URL: /en-US/docs/Web/CSS/font-palette
Title: font-palette
Flaw count: 2

  • broken_links:
    • Can't resolve /en-US/docs/Web/CSS/palette-identifier
    • Can't resolve /en-US/docs/Web/CSS/palette-identifier

URL: /en-US/docs/Web/CSS/font-palette/palette-mix
Title: palette-mix()
Flaw count: 2

  • broken_links:
    • Can't resolve /en-US/docs/Web/CSS/palette-identifier
    • Can't resolve /en-US/docs/Web/CSS/palette-mix()

URL: /en-US/docs/Web/CSS/height
Title: height
Flaw count: 1

  • broken_links:
    • Can't resolve /en-US/docs/Web/CSS/size-keyword

URL: /en-US/docs/Web/CSS/image/paint
Title: paint()
Flaw count: 1

  • broken_links:
    • Can't resolve /en-US/docs/Web/CSS/declaration-value

URL: /en-US/docs/Web/CSS/inline-size
Title: inline-size
Flaw count: 1

  • broken_links:
    • Can't resolve /en-US/docs/Web/CSS/size-keyword

URL: /en-US/docs/Web/CSS/list-style-type
Title: list-style-type
Flaw count: 4

  • broken_links:
    • Can't resolve /en-US/docs/Web/CSS/counter-style-name
    • Can't resolve /en-US/docs/Web/CSS/url-modifier
    • Can't resolve /en-US/docs/Web/CSS/url-token
    • Can't resolve /en-US/docs/Web/CSS/url-modifier

URL: /en-US/docs/Web/CSS/max-block-size
Title: max-block-size
Flaw count: 1

  • broken_links:
    • Can't resolve /en-US/docs/Web/CSS/size-keyword

URL: /en-US/docs/Web/CSS/max-height
Title: max-height
Flaw count: 1

  • broken_links:
    • Can't resolve /en-US/docs/Web/CSS/size-keyword

URL: /en-US/docs/Web/CSS/max-inline-size
Title: max-inline-size
Flaw count: 1

  • broken_links:
    • Can't resolve /en-US/docs/Web/CSS/size-keyword

URL: /en-US/docs/Web/CSS/max-width
Title: max-width
Flaw count: 1

  • broken_links:
    • Can't resolve /en-US/docs/Web/CSS/size-keyword

URL: /en-US/docs/Web/CSS/min-height
Title: min-height
Flaw count: 1

  • broken_links:
    • Can't resolve /en-US/docs/Web/CSS/size-keyword

URL: /en-US/docs/Web/CSS/min-width
Title: min-width
Flaw count: 1

  • broken_links:
    • Can't resolve /en-US/docs/Web/CSS/size-keyword

URL: /en-US/docs/Web/CSS/outline
Title: outline
Flaw count: 1

  • broken_links:
    • Can't resolve /en-US/docs/Web/CSS/outline-line-style

URL: /en-US/docs/Web/CSS/position-area
Title: position-area
Flaw count: 1

  • unknown:
    • Error parsing /shared-assets/images/diagrams/css/anchor-positioning/position-area.svg: No such file or directory (os error 2)

URL: /en-US/docs/Web/CSS/width
Title: width
Flaw count: 1

  • broken_links:
    • Can't resolve /en-US/docs/Web/CSS/size-keyword
External URLs (4)

URL: /en-US/docs/Mozilla/Firefox/Releases/16
Title: Firefox 16 for developers

URL: /en-US/docs/Mozilla/Firefox/Releases/52
Title: Firefox 52 for developers

URL: /en-US/docs/Mozilla/Firefox/Releases/68
Title: Firefox 68 for developers

(comment last updated: 2025-08-05 13:42:51)

@github-actions github-actions bot added the merge conflicts 🚧 [PR only] label Aug 5, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 5, 2025

This pull request has merge conflicts that must be resolved before it can be merged.

@github-actions github-actions bot removed the merge conflicts 🚧 [PR only] label Aug 5, 2025
dipikabh
dipikabh approved these changes Aug 5, 2025
View reviewed changes
Copy link
Contributor

@dipikabh dipikabh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

@dipikabh dipikabh merged commit 6358207 into mdn:main Aug 5, 2025
8 checks passed
@Josh-Cena Josh-Cena deleted the css-keyword-case branch August 5, 2025 14:06
@Josh-Cena Josh-Cena mentioned this pull request Aug 6, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dipikabh dipikabh dipikabh approved these changes

@bsmth bsmth Awaiting requested review from bsmth

Assignees
No one assigned
Labels
Content:Accessibility Accessibility docs Content:CSS Cascading Style Sheets docs Content:Firefox Content in the Mozilla/Firefox subtree Content:Glossary Glossary entries Content:HTML Hypertext Markup Language docs Content:Learn Learning area docs Content:MathML MathML docs Content:SVG SVG docs Content:WebAPI Web API docs size/l [PR only] 501-1000 LoC changed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Josh-Cena @dipikabh