Skip to content

update to go1.24.3 #49174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 12, 2025
Merged

update to go1.24.3 #49174

merged 2 commits into from
May 12, 2025

Conversation

thaJeztah
Copy link
Member

@thaJeztah thaJeztah commented Dec 30, 2024 •
edited by vvoland
Loading

@thaJeztah thaJeztah added this to the 29.0.0 milestone Dec 30, 2024
@thaJeztah thaJeztah self-assigned this Dec 30, 2024
@thaJeztah thaJeztah force-pushed the bump_golang_1.24 branch 3 times, most recently from b7625bd to 8b8a594 Compare December 30, 2024 13:07
@thaJeztah
Copy link
Member Author

Hmmm. interesting; unit tests failed to build on Windows? can't see the actual failure though;

=== Failed
=== FAIL: github.com/docker/docker/distribution  (0.00s)
FAIL	github.com/docker/docker/distribution [build failed]
FAIL	github.com/docker/docker/distribution [build failed]

=== FAIL: github.com/docker/docker/libnetwork/drivers/windows  (0.00s)
FAIL	github.com/docker/docker/libnetwork/drivers/windows [build failed]
FAIL	github.com/docker/docker/libnetwork/drivers/windows [build failed]

=== FAIL: github.com/docker/docker/libnetwork/drivers/windows/overlay  (0.00s)
FAIL	github.com/docker/docker/libnetwork/drivers/windows/overlay [build failed]
FAIL	github.com/docker/docker/libnetwork/drivers/windows/overlay [build failed]

@thaJeztah
Copy link
Member Author

Looks like some error messages changed;

=== RUN   TestDaemonConfigurationFeatures/invalid_config_value
    config_linux_test.go:182: assertion failed: expected error "json: cannot unmarshal string into Go struct field Config.features of type bool", got "json: cannot unmarshal string into Go struct field Config.CommonConfig.features of type bool"
--- FAIL: TestDaemonConfigurationFeatures/invalid_config_value (0.00s)


=== RUN   TestDaemonConfigurationHostGatewayIP/config_not_array
    config_linux_test.go:354: assertion failed: expected error "json: cannot unmarshal string into Go struct field Config.host-gateway-ips of type []netip.Addr", got "json: cannot unmarshal string into Go struct field Config.CommonConfig.DNSConfig.host-gateway-ips of type []netip.Addr"
--- FAIL: TestDaemonConfigurationHostGatewayIP/config_not_array (0.00s)

Expected / actual: looks like the error message now includes nested structs:

json: cannot unmarshal string into Go struct field Config.features of type bool
json: cannot unmarshal string into Go struct field Config.CommonConfig.features of type bool


json: cannot unmarshal string into Go struct field Config.host-gateway-ips of type []netip.Addr
json: cannot unmarshal string into Go struct field Config.CommonConfig.DNSConfig.host-gateway-ips of type []netip.Addr

@thaJeztah
Copy link
Member Author

☝️ Looks related to golang/go@0fe6347 / https://go-review.googlesource.com/c/go/+/606956 to address;

@thaJeztah thaJeztah mentioned this pull request Jan 1, 2025
Merged
@robmry
Copy link
Contributor

robmry commented Jan 2, 2025

Hmmm. interesting; unit tests failed to build on Windows? can't see the actual failure though;

It was a battle (!), but here you go ...

# github.com/docker/docker/libnetwork/drivers/windows
# [github.com/docker/docker/libnetwork/drivers/windows]
.\windows.go:449:33: non-constant format string in call to github.com/docker/docker/libnetwork/types.ForbiddenErrorf
FAIL    github.com/docker/docker/libnetwork/drivers/windows [build failed]

# github.com/docker/docker/libnetwork/drivers/windows/overlay
.\ov_network_windows.go:206:32: non-constant format string in call to github.com/docker/docker/libnetwork/types.ForbiddenErrorf
FAIL    github.com/docker/docker/libnetwork/drivers/windows/overlay [build failed]

# github.com/docker/docker/distribution
# [github.com/docker/docker/distribution]
.\pull_v2_windows.go:145:35: non-constant format string in call to (*github.com/docker/docker/vendor/github.com/sirupsen/logrus.Entry).Debugf
FAIL    github.com/docker/docker/distribution [build failed]

@thaJeztah thaJeztah mentioned this pull request Jan 2, 2025
Merged
@thaJeztah thaJeztah force-pushed the bump_golang_1.24 branch 2 times, most recently from 294cc26 to 6dcc10b Compare January 2, 2025 22:26
@thaJeztah thaJeztah changed the title update to go1.24rc1 update to go1.24.0 Feb 14, 2025
@thaJeztah thaJeztah mentioned this pull request Feb 21, 2025
Open
@thaJeztah thaJeztah changed the title update to go1.24.0 update to go1.24.2 Apr 5, 2025
@thaJeztah thaJeztah force-pushed the bump_golang_1.24 branch from 2af059f to 03076be Compare May 8, 2025 09:46
@thaJeztah thaJeztah changed the title update to go1.24.2 update to go1.24.3 May 8, 2025
@thaJeztah thaJeztah marked this pull request as ready for review May 8, 2025 09:57
@thaJeztah thaJeztah requested a review from tianon as a code owner May 8, 2025 09:57
@thaJeztah thaJeztah mentioned this pull request May 8, 2025
Merged
@thompson-shaun thompson-shaun requested review from dmcgowan and vvoland May 8, 2025 18:50
vvoland
vvoland reviewed May 12, 2025
View reviewed changes
.github/workflows/.windows.yml Outdated
@@ -92,7 +92,6 @@ jobs:
& docker build `
--build-arg WINDOWS_BASE_IMAGE `
--build-arg WINDOWS_BASE_IMAGE_TAG `
--build-arg GO_VERSION `
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this intended?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Possibly related to that as well. That said, I wonder if we need to pass it, given that we update the GO_VERSION inside the Dockerfile as well 🤔 But probably best for separate.

.github/workflows/buildkit.yml Outdated
Comment on lines 154 to 155
env:
GO_VERSION: "1.24.3"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this needed if we already have the GO_VERSION declared at the top?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔 trying to recall why I did this; perhaps this was related to the pre-releases (when I first created this branch, go1.24 was still a pre-release, which uses a different format for the versions?)

thaJeztah added 2 commits May 12, 2025 10:31
@thaJeztah
update to go1.24.3
e991c71 
release notes: https://go.dev/doc/go1.24

Signed-off-by: Sebastiaan van Stijn <[email protected]>
@thaJeztah
hack/make/.binary: update link to go source for "pie" support
1cf7d7e 
Keeping it up to date, in case the situation changes.

Signed-off-by: Sebastiaan van Stijn <[email protected]>
@thaJeztah
Copy link
Member Author

@vvoland updated; removed those changes

vvoland
vvoland approved these changes May 12, 2025
View reviewed changes
Copy link
Contributor

@vvoland vvoland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@vvoland vvoland merged commit 4c189b8 into moby:master May 12, 2025
141 checks passed
@thaJeztah thaJeztah mentioned this pull request May 12, 2025
Closed
@vvoland vvoland modified the milestones: 29.0.0, 28.2.0 May 12, 2025
@thaJeztah thaJeztah deleted the bump_golang_1.24 branch May 19, 2025 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmcgowan dmcgowan dmcgowan approved these changes

@vvoland vvoland vvoland approved these changes

@tianon tianon Awaiting requested review from tianon tianon is a code owner

Assignees

@dmcgowan dmcgowan

@thaJeztah thaJeztah

@vvoland vvoland

Labels
area/packaging area/testing impact/changelog status/2-code-review
Projects
None yet
Milestone
28.2.0
Development

Successfully merging this pull request may close these issues.
4 participants
@thaJeztah @robmry @dmcgowan @vvoland