Skip to content

Set EnableIPv4=true in overlay network inspect response #50147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 5, 2025
Merged

Set EnableIPv4=true in overlay network inspect response #50147

merged 1 commit into from
Jun 5, 2025

Conversation

robmry
Copy link
Contributor

@robmry robmry commented Jun 5, 2025 •
edited
Loading

- What I did

Overlay networks always have IPv4, so report that in network inspect responses.

- How I did it

- How to verify it

Create an overlay network and inspect it ...

$ docker network inspect ovl
[
    {
        "Name": "ovl",
        "Id": "s10uawdvkhyf2iaopfpu3y7o3",
        "Created": "2025-06-05T14:20:44.778231219Z",
        "Scope": "swarm",
        "Driver": "overlay",
        "EnableIPv4": true,
        "EnableIPv6": false,
        ...
    }
]

- Human readable description for the release notes

- The `network inspect` response for an overlay network now reports that `EnableIPv4` is true.

@robmry robmry added this to the 28.2.3 milestone Jun 5, 2025
@robmry robmry self-assigned this Jun 5, 2025
@robmry robmry marked this pull request as ready for review June 5, 2025 15:46
@robmry robmry requested review from dmcgowan, corhere and vvoland June 5, 2025 15:47
thaJeztah
thaJeztah approved these changes Jun 5, 2025
View reviewed changes
Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztah thaJeztah merged commit 59bdc72 into moby:master Jun 5, 2025
229 of 231 checks passed
@vvoland vvoland modified the milestones: 28.2.3, 28.3.0 Jun 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@corhere corhere corhere approved these changes

@thaJeztah thaJeztah thaJeztah approved these changes

@dmcgowan dmcgowan Awaiting requested review from dmcgowan

@vvoland vvoland Awaiting requested review from vvoland

Assignees

@robmry robmry

Labels
area/networking/d/overlay area/networking impact/changelog kind/bugfix PR's that fix bugs version/28.0
Projects
None yet
Milestone
28.3.0
Development

Successfully merging this pull request may close these issues.

Overlay network reports "EnableIPv4": false
4 participants
@robmry @corhere @thaJeztah @vvoland