Skip to content

[28.x]: Revert overlay bug fixes / refactoring #50169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Jun 13, 2025
Merged

[28.x]: Revert overlay bug fixes / refactoring #50169

merged 14 commits into from
Jun 13, 2025

Conversation

robmry
Copy link
Contributor

@robmry robmry commented Jun 11, 2025 •
edited by vvoland
Loading

- What I did

Revert overlay network fixes/refactoring from 28.2.x ... a regression has been reported in #50129. But, so far, we've been unable to repro or narrow down the problem. So, let's try removing these changes for 28.3.0.

These PRs/commits are still present in master, for further investigation.

I've not reverted these ...

- How I did it

- How to verify it

- Human readable description for the release notes

- Revert Swarm related changes added in 28.2.x builds, due to a regression reported in https://github.com/moby/moby/issues/50129.
  * Revert: Improve the reliability of NetworkDB in busy clusters and lossy networks (https://github.com/moby/moby/pull/49932)
  * Revert: Fix an issue where the load-balancer IP address for an overlay network would not be released in certain cases if the Swarm was lacking an ingress network (https://github.com/moby/moby/pull/49948)
  * Revert: Fix an issue where `docker network inspect --verbose` could sometimes crash the daemon (https://github.com/moby/moby/pull/49937)
  * Revert: Improvements to the reliability and convergence speed of NetworkDB (https://github.com/moby/moby/pull/49939)

robmry added 14 commits June 11, 2025 12:05
@robmry
Revert "libn/d/overlay: use netip types more"
78ccc20 
This reverts commit d188df0.

Signed-off-by: Rob Murray <[email protected]>
@robmry
Revert "libnetwork/internal/setmatrix: make keys generic"
ea818a7 
This reverts commit 0317f77.

Signed-off-by: Rob Murray <[email protected]>
@robmry
Revert "libnetwork/osl: stop tracking neighbor entries"
5d6ae34 
This reverts commit 0d6e7cd.

Signed-off-by: Rob Murray <[email protected]>
@robmry
Revert "libnetwork/osl: remove superfluous locks in Namespace"
3eb59ba 
This reverts commit 9866738.

Signed-off-by: Rob Murray <[email protected]>
@robmry
Revert "libn/osl: refactor func (*Namespace) AddNeighbor"
35916f0 
This reverts commit b6d76eb.

Signed-off-by: Rob Murray <[email protected]>
@robmry
Revert "libn/osl: drop unused AddNeighbor force parameter"
b5b349d 
This reverts commit 3bdf99d.

Signed-off-by: Rob Murray <[email protected]>
@robmry
Revert "libn/networkdb: stop table events from racing network leaves"
cc60ec8 
This reverts commit 270a4d4.

Signed-off-by: Rob Murray <[email protected]>
@robmry
Revert "libn/networkdb: Watch() without race conditions"
2297ae3 
This reverts commit a3aea15.

Signed-off-by: Rob Murray <[email protected]>
@robmry
Revert "libn/networkdb: record tombstones for all deletes"
576cf73 
This reverts commit ada8bc3.

Signed-off-by: Rob Murray <[email protected]>
@robmry
Revert "libn/networkdb: b'cast watch events from local POV"
cfd5e5e 
This reverts commit c68671d.

Signed-off-by: Rob Murray <[email protected]>
@robmry
Revert "libnetwork/networkdb: use correct index in GetTableByNetwork"
e079583 
This reverts commit d5c370d.

Signed-off-by: Rob Murray <[email protected]>
@robmry
Revert "Fix possible overlapping IPs when ingressNA == nil"
83b2fc2 
This reverts commit 56ad941.

Signed-off-by: Rob Murray <[email protected]>
@robmry
Revert "libn/networkdb: fix data race in GetTableByNetwork"
0df31cf 
This reverts commit ec65f2d.

Signed-off-by: Rob Murray <[email protected]>
@robmry
Revert "libn/networkdb: don't exceed broadcast size limit"
7acb079 
This reverts commit dacf445.

Signed-off-by: Rob Murray <[email protected]>
@robmry robmry added this to the 28.3.0 milestone Jun 11, 2025
@robmry robmry self-assigned this Jun 11, 2025
@robmry robmry changed the title 28.x: Revert overlay bug fixes / refactoring [28.x]: Revert overlay bug fixes / refactoring Jun 11, 2025
@robmry robmry marked this pull request as ready for review June 12, 2025 10:55
@robmry robmry requested a review from corhere June 12, 2025 10:55
@vvoland vvoland merged commit 6a1fb46 into moby:28.x Jun 13, 2025
211 of 226 checks passed
@bdoublet91 bdoublet91 mentioned this pull request Jun 17, 2025
Closed
@corhere corhere mentioned this pull request Jun 25, 2025
Closed
@buckaroogeek buckaroogeek mentioned this pull request Jun 25, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@corhere corhere corhere approved these changes

@vvoland vvoland vvoland approved these changes

Assignees

@robmry robmry

Labels
area/networking/d/overlay area/networking area/swarm impact/changelog kind/bugfix PR's that fix bugs version/28.2
Projects
None yet
Milestone
28.3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@robmry @corhere @vvoland