Skip to content

[PyTorch] Copy vectors less in Function::append_operator #63977

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 7 commits into from
Closed

[PyTorch] Copy vectors less in Function::append_operator #63977

wants to merge 7 commits into from

Conversation

swolchok
Copy link
Contributor

@swolchok swolchok commented Aug 25, 2021 •
edited
Loading

@swolchok
[PyTorch] Copy vectors less in Function::append_operator
cd68517 
Doesn't seem to be any reason to copy these argument vectors.

Differential Revision: [D30550301](https://our.internmc.facebook.com/intern/diff/D30550301/)

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Aug 25, 2021 •
edited
Loading

🔗 Helpful links

💊 CI failures summary and remediations

As of commit a1006ea (more details on the Dr. CI page):

  • 1/1 failures introduced in this PR

🕵️ 1 new failure recognized by patterns

The following CI failures do not appear to be due to upstream breakages:

See GitHub Actions build win-vs2019-cuda10.1-py3 / test (default, 1, 1, windows.8xlarge.nvidia.gpu) (1/1)

Step: "Install Cuda" (full log | diagnosis details | 🔁 rerun)

2021-09-08T17:31:09.6462602Z ls: cannot access ...UDA/v10.1/bin/nvcc.exe': No such file or directory 
2021-09-08T17:31:06.7534917Z 
2021-09-08T17:31:06.7535465Z Folders: 11
2021-09-08T17:31:06.7536059Z Files: 130
2021-09-08T17:31:06.7536637Z Size:       907512
2021-09-08T17:31:06.7537274Z Compressed: 111420
2021-09-08T17:31:06.7604230Z + mkdir -p 'C:/Program Files/NVIDIA Corporation/NvToolsExt'
2021-09-08T17:31:06.8016642Z + cp -r NvToolsExt/bin NvToolsExt/docs NvToolsExt/include NvToolsExt/lib NvToolsExt/samples 'C:/Program Files/NVIDIA Corporation/NvToolsExt/'
2021-09-08T17:31:09.6273373Z + export 'NVTOOLSEXT_PATH=C:\Program Files\NVIDIA Corporation\NvToolsExt\'
2021-09-08T17:31:09.6275082Z + NVTOOLSEXT_PATH='C:\Program Files\NVIDIA Corporation\NvToolsExt\'
2021-09-08T17:31:09.6277151Z + ls '/c/Program Files/NVIDIA GPU Computing Toolkit/CUDA/v10.1/bin/nvcc.exe'
2021-09-08T17:31:09.6462602Z ls: cannot access '/c/Program Files/NVIDIA GPU Computing Toolkit/CUDA/v10.1/bin/nvcc.exe': No such file or directory
2021-09-08T17:31:09.6466220Z + echo 'CUDA installation failed'
2021-09-08T17:31:09.6467474Z CUDA installation failed
2021-09-08T17:31:09.6468419Z + mkdir -p /c/w/build-results
2021-09-08T17:31:09.6657164Z + 7z a 'c:\w\build-results\cuda_install_logs.7z' cuda_install_logs
2021-09-08T17:31:11.1062585Z 
2021-09-08T17:31:11.1063930Z 7-Zip 19.00 (x64) : Copyright (c) 1999-2018 Igor Pavlov : 2019-02-21
2021-09-08T17:31:11.1064885Z 
2021-09-08T17:31:11.1065557Z Scanning the drive:
2021-09-08T17:31:11.1066223Z 1 folder, 2 files, 4205427 bytes (4107 KiB)
2021-09-08T17:31:11.1066676Z
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@facebook-github-bot facebook-github-bot added oncall: jit Add this issue/PR to JIT oncall triage queue cla signed labels Aug 25, 2021
This was referenced Aug 25, 2021
Closed
Closed
swolchok added a commit that referenced this pull request Aug 25, 2021
@swolchok
[PyTorch] Copy vectors less in Function::append_operator
11fedf0 
Doesn't seem to be any reason to copy these argument vectors.

Differential Revision: [D30550301](https://our.internmc.facebook.com/intern/diff/D30550301/)

ghstack-source-id: 136667075
Pull Request resolved: #63977
@swolchok swolchok mentioned this pull request Aug 25, 2021
Closed
@swolchok
Update on "[PyTorch] Copy vectors less in Function::append_operator"
89dc978 
Doesn't seem to be any reason to copy these argument vectors.

Differential Revision: [D30550301](https://our.internmc.facebook.com/intern/diff/D30550301/)

[ghstack-poisoned]
This was referenced Aug 26, 2021
Closed
Closed
Closed
Closed
Closed
Closed
Closed
@swolchok
Update on "[PyTorch] Copy vectors less in Function::append_operator"
80b5e14 
Doesn't seem to be any reason to copy these argument vectors.

Differential Revision: [D30550301](https://our.internmc.facebook.com/intern/diff/D30550301/)

[ghstack-poisoned]
@swolchok swolchok mentioned this pull request Aug 30, 2021
Closed
@swolchok
Update on "[PyTorch] Copy vectors less in Function::append_operator"
8c3d3cc 
Doesn't seem to be any reason to copy these argument vectors.

Differential Revision: [D30550301](https://our.internmc.facebook.com/intern/diff/D30550301/)

[ghstack-poisoned]
This was referenced Aug 31, 2021
Closed
Closed
@swolchok
Update on "[PyTorch] Copy vectors less in Function::append_operator"
8670b1d 
Doesn't seem to be any reason to copy these argument vectors.

Differential Revision: [D30550301](https://our.internmc.facebook.com/intern/diff/D30550301/)

[ghstack-poisoned]
@swolchok
Update on "[PyTorch] Copy vectors less in Function::append_operator"
d8c4527 
Doesn't seem to be any reason to copy these argument vectors.

Differential Revision: [D30550301](https://our.internmc.facebook.com/intern/diff/D30550301/)

[ghstack-poisoned]
@swolchok
Update on "[PyTorch] Copy vectors less in Function::append_operator"
a1006ea 
Doesn't seem to be any reason to copy these argument vectors.

Differential Revision: [D30550301](https://our.internmc.facebook.com/intern/diff/D30550301/)

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

This pull request has been merged in f5e76b4.

@facebook-github-bot facebook-github-bot deleted the gh/swolchok/272/head branch September 12, 2021 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla signed Merged oncall: jit Add this issue/PR to JIT oncall triage queue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@swolchok @facebook-github-bot