[PyTorch][Static Runtime] Support memory planning for to without requiring copying #67223

swolchok · 2021-10-25T21:33:46Z

Stack from ghstack:

Differential Revision: D31776259

… requiring copying Differential Revision: [D31776259](https://our.internmc.facebook.com/intern/diff/D31776259/) [ghstack-poisoned]

pytorch-probot · 2021-10-25T21:33:49Z

CI Flow Status

⚛️ CI Flow

Ruleset - Version: v1
Ruleset - File: https://github.com/pytorch/pytorch/blob/9e9d020e53b708f362a5d859a6a77a9974907a67/.github/generated-ciflow-ruleset.json
PR ciflow labels: ciflow/default

Workflows	Labels (bold enabled)	Status
Triggered Workflows
linux-bionic-py3.7-clang9	`ciflow/all`, `ciflow/cpu`, `ciflow/default`, `ciflow/linux`, `ciflow/noarch`, `ciflow/trunk`	✅ triggered
linux-docs	`ciflow/all`, `ciflow/cpu`, `ciflow/default`, `ciflow/docs`, `ciflow/linux`, `ciflow/trunk`	✅ triggered
linux-vulkan-bionic-py3.7-clang9	`ciflow/all`, `ciflow/cpu`, `ciflow/default`, `ciflow/linux`, `ciflow/trunk`, `ciflow/vulkan`	✅ triggered
linux-xenial-cuda11.3-py3.7-gcc7	`ciflow/all`, `ciflow/cuda`, `ciflow/default`, `ciflow/linux`, `ciflow/trunk`	✅ triggered
linux-xenial-cuda11.3-py3.7-gcc7-bazel-test	`ciflow/all`, `ciflow/bazel`, `ciflow/cpu`, `ciflow/default`, `ciflow/linux`, `ciflow/trunk`	✅ triggered
linux-xenial-py3-clang5-mobile-build	`ciflow/all`, `ciflow/default`, `ciflow/linux`, `ciflow/mobile`, `ciflow/trunk`	✅ triggered
linux-xenial-py3-clang5-mobile-custom-build-static	`ciflow/all`, `ciflow/default`, `ciflow/linux`, `ciflow/mobile`, `ciflow/trunk`	✅ triggered
linux-xenial-py3.7-clang7-asan	`ciflow/all`, `ciflow/cpu`, `ciflow/default`, `ciflow/linux`, `ciflow/sanitizers`, `ciflow/trunk`	✅ triggered
linux-xenial-py3.7-clang7-onnx	`ciflow/all`, `ciflow/cpu`, `ciflow/default`, `ciflow/linux`, `ciflow/onnx`, `ciflow/trunk`	✅ triggered
linux-xenial-py3.7-gcc5.4	`ciflow/all`, `ciflow/cpu`, `ciflow/default`, `ciflow/linux`, `ciflow/trunk`	✅ triggered
linux-xenial-py3.7-gcc7	`ciflow/all`, `ciflow/cpu`, `ciflow/default`, `ciflow/linux`, `ciflow/trunk`	✅ triggered
pytorch-linux-xenial-py3-clang5-android-ndk-r19c-gradle-custom-build-single	`ciflow/all`, `ciflow/android`, `ciflow/cpu`, `ciflow/default`, `ciflow/linux`, `ciflow/trunk`	✅ triggered
pytorch-linux-xenial-py3-clang5-android-ndk-r19c-gradle-custom-build-single-full-jit	`ciflow/all`, `ciflow/android`, `ciflow/cpu`, `ciflow/default`, `ciflow/linux`, `ciflow/trunk`	✅ triggered
win-vs2019-cpu-py3	`ciflow/all`, `ciflow/cpu`, `ciflow/default`, `ciflow/trunk`, `ciflow/win`	✅ triggered
win-vs2019-cuda11.3-py3	`ciflow/all`, `ciflow/cuda`, `ciflow/default`, `ciflow/trunk`, `ciflow/win`	✅ triggered
Skipped Workflows
caffe2-linux-xenial-py3.7-gcc5.4	`ciflow/all`, `ciflow/cpu`, `ciflow/linux`, `ciflow/trunk`	🚫 skipped
docker-builds	`ciflow/all`, `ciflow/trunk`	🚫 skipped
ios-12-5-1-arm64	`ciflow/all`, `ciflow/ios`, `ciflow/macos`, `ciflow/trunk`	🚫 skipped
ios-12-5-1-arm64-coreml	`ciflow/all`, `ciflow/ios`, `ciflow/macos`, `ciflow/trunk`	🚫 skipped
ios-12-5-1-arm64-custom-ops	`ciflow/all`, `ciflow/ios`, `ciflow/macos`, `ciflow/trunk`	🚫 skipped
ios-12-5-1-arm64-full-jit	`ciflow/all`, `ciflow/ios`, `ciflow/macos`, `ciflow/trunk`	🚫 skipped
ios-12-5-1-arm64-metal	`ciflow/all`, `ciflow/ios`, `ciflow/macos`, `ciflow/trunk`	🚫 skipped
ios-12-5-1-x86-64	`ciflow/all`, `ciflow/ios`, `ciflow/macos`, `ciflow/trunk`	🚫 skipped
ios-12-5-1-x86-64-coreml	`ciflow/all`, `ciflow/ios`, `ciflow/macos`, `ciflow/trunk`	🚫 skipped
ios-12-5-1-x86-64-full-jit	`ciflow/all`, `ciflow/ios`, `ciflow/macos`, `ciflow/trunk`	🚫 skipped
libtorch-linux-xenial-cuda10.2-py3.7-gcc7	`ciflow/all`, `ciflow/cuda`, `ciflow/libtorch`, `ciflow/linux`, `ciflow/trunk`	🚫 skipped
libtorch-linux-xenial-cuda11.3-py3.7-gcc7	`ciflow/all`, `ciflow/cuda`, `ciflow/libtorch`, `ciflow/linux`, `ciflow/trunk`	🚫 skipped
linux-bionic-cuda10.2-py3.9-gcc7	`ciflow/all`, `ciflow/cuda`, `ciflow/linux`, `ciflow/slow`, `ciflow/trunk`	🚫 skipped
linux-docs-push	`ciflow/all`, `ciflow/cpu`, `ciflow/linux`, `ciflow/scheduled`	🚫 skipped
macos-10-15-py3-arm64	`ciflow/all`, `ciflow/macos`, `ciflow/trunk`	🚫 skipped
macos-10-15-py3-lite-interpreter-x86-64	`ciflow/all`, `ciflow/macos`, `ciflow/trunk`	🚫 skipped
macos-11-py3-x86-64	`ciflow/all`, `ciflow/macos`, `ciflow/trunk`	🚫 skipped
parallelnative-linux-xenial-py3.7-gcc5.4	`ciflow/all`, `ciflow/cpu`, `ciflow/linux`, `ciflow/trunk`	🚫 skipped
periodic-libtorch-linux-bionic-cuda11.5-py3.7-gcc7	`ciflow/all`, `ciflow/cuda`, `ciflow/libtorch`, `ciflow/linux`, `ciflow/scheduled`	🚫 skipped
periodic-libtorch-linux-xenial-cuda11.1-py3.7-gcc7	`ciflow/all`, `ciflow/cuda`, `ciflow/libtorch`, `ciflow/linux`, `ciflow/scheduled`	🚫 skipped
periodic-linux-bionic-cuda11.5-py3.7-gcc7	`ciflow/all`, `ciflow/cuda`, `ciflow/linux`, `ciflow/scheduled`	🚫 skipped
periodic-linux-xenial-cuda10.2-py3-gcc7-slow-gradcheck	`ciflow/all`, `ciflow/cuda`, `ciflow/linux`, `ciflow/scheduled`, `ciflow/slow`, `ciflow/slow-gradcheck`	🚫 skipped
periodic-linux-xenial-cuda11.1-py3.7-gcc7-debug	`ciflow/all`, `ciflow/cuda`, `ciflow/linux`, `ciflow/scheduled`	🚫 skipped
periodic-win-vs2019-cuda11.1-py3	`ciflow/all`, `ciflow/cuda`, `ciflow/scheduled`, `ciflow/win`	🚫 skipped
periodic-win-vs2019-cuda11.5-py3	`ciflow/all`, `ciflow/cuda`, `ciflow/scheduled`, `ciflow/win`	🚫 skipped
pytorch-linux-xenial-py3-clang5-android-ndk-r19c-build	`ciflow/all`, `ciflow/android`, `ciflow/cpu`, `ciflow/linux`, `ciflow/trunk`	🚫 skipped

You can add a comment to the PR and tag @pytorchbot with the following commands:

# ciflow rerun, "ciflow/default" will always be added automatically
@pytorchbot ciflow rerun

# ciflow rerun with additional labels "-l <ciflow/label_name>", which is equivalent to adding these labels manually and trigger the rerun
@pytorchbot ciflow rerun -l ciflow/scheduled -l ciflow/slow

For more information, please take a look at the CI Flow Wiki.

facebook-github-bot · 2021-10-25T21:34:09Z

🔗 Helpful links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/67223
📄 Preview docs built from this PR
📄 Preview C++ docs built from this PR
↩️ [fb-only] Re-run with SSH instructions
🔧 Opt-in to CIFlow to control what jobs run on your PRs

💊 CI failures summary and remediations

As of commit 9e9d020 (more details on the Dr. CI page):

1/1 failures introduced in this PR

🕵️ 1 new failure recognized by patterns

The following CI failures do not appear to be due to upstream breakages:

linux-xenial-py3.7-clang7-asan / test (default, 1, 3, linux.2xlarge) (1/1)

Step: "Unknown" (full log | diagnosis details | 🔁 rerun)

2022-01-04T21:23:30.9579616Z SUMMARY: Undefined.../jenkins/workspace/aten/src/ATen/Utils.cpp:20:3 in

2022-01-04T21:23:30.9057742Z     #10 0x565049b3d801 in run_mod /tmp/build/80754af9/python_1627392990942/work/Python/pythonrun.c:1037
2022-01-04T21:23:30.9058474Z     #11 0x565049b487a9 in PyRun_StringFlags /tmp/build/80754af9/python_1627392990942/work/Python/pythonrun.c:961
2022-01-04T21:23:30.9059279Z     #12 0x565049b4880b in PyRun_SimpleStringFlags /tmp/build/80754af9/python_1627392990942/work/Python/pythonrun.c:455
2022-01-04T21:23:30.9060033Z     #13 0x565049b48908 in pymain_run_command /tmp/build/80754af9/python_1627392990942/work/Modules/main.c:420
2022-01-04T21:23:30.9060708Z     #14 0x565049b48908 in pymain_run_python /tmp/build/80754af9/python_1627392990942/work/Modules/main.c:2907
2022-01-04T21:23:30.9061356Z     #15 0x565049b48908 in pymain_main /tmp/build/80754af9/python_1627392990942/work/Modules/main.c:3460
2022-01-04T21:23:30.9062002Z     #16 0x565049b48ccb in _Py_UnixMain /tmp/build/80754af9/python_1627392990942/work/Modules/main.c:3495
2022-01-04T21:23:30.9577318Z     #17 0x7f6de21ac83f in __libc_start_main /build/glibc-S7Ft5T/glibc-2.23/csu/../csu/libc-start.c:291
2022-01-04T21:23:30.9578335Z     #18 0x565049aed554 in _start (/opt/conda/bin/python3.7+0x1d7554)
2022-01-04T21:23:30.9578694Z 
2022-01-04T21:23:30.9579616Z SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior /var/lib/jenkins/workspace/aten/src/ATen/Utils.cpp:20:3 in 
2022-01-04T21:23:30.9776143Z + retcode=1
2022-01-04T21:23:30.9777166Z + set -e
2022-01-04T21:23:30.9777756Z + return 1
2022-01-04T21:23:30.9779903Z + [[ linux-xenial-py3.7-clang7-asan-default == *-NO_AVX-* ]]
2022-01-04T21:23:30.9781096Z + [[ default == \n\o\g\p\u\_\N\O\_\A\V\X ]]
2022-01-04T21:23:30.9782673Z + [[ linux-xenial-py3.7-clang7-asan-default == *-NO_AVX2-* ]]
2022-01-04T21:23:30.9783963Z + [[ default == \n\o\g\p\u\_\N\O\_\A\V\X\2 ]]
2022-01-04T21:23:30.9785464Z + [[ linux-xenial-py3.7-clang7-asan-default == *-NO_AVX512-* ]]
2022-01-04T21:23:30.9786731Z + [[ default == \n\o\g\p\u\_\N\O\_\A\V\X\5\1\2 ]]
2022-01-04T21:23:30.9788192Z + [[ linux-xenial-py3.7-clang7-asan-default == *tbb* ]]

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

… requiring copying Differential Revision: [D31776259](https://our.internmc.facebook.com/intern/diff/D31776259/) ghstack-source-id: 141496824 Pull Request resolved: #67223

eellison

@navahgar is working on a first invocation of SR that would give dtype/device on the tensors after that we should be able to statically tell whether to is a no-op or will copy. would it be easier to integrate with those changes than add all this ?

… to without requiring copying" Differential Revision: [D31776259](https://our.internmc.facebook.com/intern/diff/D31776259/) [ghstack-poisoned]

… requiring copying Pull Request resolved: #67223 ghstack-source-id: 141748858 Differential Revision: [D31776259](https://our.internmc.facebook.com/intern/diff/D31776259/)

… to without requiring copying" Differential Revision: [D31776259](https://our.internmc.facebook.com/intern/diff/D31776259/) [ghstack-poisoned]

… requiring copying Pull Request resolved: #67223 ghstack-source-id: 142215025 Differential Revision: [D31776259](https://our.internmc.facebook.com/intern/diff/D31776259/)

… to without requiring copying" Differential Revision: [D31776259](https://our.internmc.facebook.com/intern/diff/D31776259/) [ghstack-poisoned]

…requiring copying Pull Request resolved: #67223 ghstack-source-id: 144507292 Differential Revision: [D31776259](https://our.internmc.facebook.com/intern/diff/D31776259/)

… to without requiring copying" Differential Revision: [D31776259](https://our.internmc.facebook.com/intern/diff/D31776259/) [ghstack-poisoned]

…requiring copying (#67223) Summary: Pull Request resolved: #67223 ghstack-source-id: 146482215 Test Plan: See perf measurements on ctr_mobile_feed local_ro net for this stack: P467203421 (local is neutral: P467267554) Reviewed By: hlu1 Differential Revision: D31776259 fbshipit-source-id: f84fcaa05029577213f3bf2ae9d4b987b68480b3

[PyTorch][Static Runtime] WIP: support memory planning for to without…

f602885

… requiring copying Differential Revision: [D31776259](https://our.internmc.facebook.com/intern/diff/D31776259/) [ghstack-poisoned]

pytorch-probot bot added the ciflow/default label Oct 25, 2021

facebook-github-bot added the cla signed label Oct 25, 2021

facebook-github-bot added the oncall: jit Add this issue/PR to JIT oncall triage queue label Oct 25, 2021

eellison reviewed Oct 26, 2021

View reviewed changes

Update on "[PyTorch][Static Runtime] WIP: support memory planning for…

c8e3a7c

… to without requiring copying" Differential Revision: [D31776259](https://our.internmc.facebook.com/intern/diff/D31776259/) [ghstack-poisoned]

swolchok mentioned this pull request Oct 27, 2021

[PyTorch][Static Runtime] Fix dtype changing between iterations for to() #67394

Closed

Update on "[PyTorch][Static Runtime] WIP: support memory planning for…

5ce5589

… to without requiring copying" Differential Revision: [D31776259](https://our.internmc.facebook.com/intern/diff/D31776259/) [ghstack-poisoned]

This was referenced Nov 2, 2021

[PyTorch][Static Runtime][easy] give to_copy_functor a name #67701

Closed

[PyTorch][Static Runtime] Don't track scalar ivalues #67702

Closed

Update on "[PyTorch][Static Runtime] WIP: support memory planning for…

ee736e5

… to without requiring copying" Differential Revision: [D31776259](https://our.internmc.facebook.com/intern/diff/D31776259/) [ghstack-poisoned]

This was referenced Nov 10, 2021

[PyTorch][Static Runtime] Save 2 pointers in ProcessedNode #67860

Closed

[PyTorch][Static Runtime] Switch input/output repr to 2-byte offsets #67934

Closed

[PyTorch][Static Runtime] Add & use "small array" for ProcessedNodeInputs #67935

Closed

swolchok added 2 commits November 29, 2021 12:12

Update on "[PyTorch][Static Runtime] WIP: support memory planning for…

d91ad81

… to without requiring copying" Differential Revision: [D31776259](https://our.internmc.facebook.com/intern/diff/D31776259/) [ghstack-poisoned]

Update on "[PyTorch][Static Runtime] WIP: support memory planning for…

e4af0ac

… to without requiring copying" Differential Revision: [D31776259](https://our.internmc.facebook.com/intern/diff/D31776259/) [ghstack-poisoned]

swolchok added 9 commits December 8, 2021 12:32

Update on "[PyTorch][Static Runtime] WIP: support memory planning for…

0525d88

… to without requiring copying" Differential Revision: [D31776259](https://our.internmc.facebook.com/intern/diff/D31776259/) [ghstack-poisoned]

Update on "[PyTorch][Static Runtime] WIP: support memory planning for…

1a3d5bd

… to without requiring copying" Differential Revision: [D31776259](https://our.internmc.facebook.com/intern/diff/D31776259/) [ghstack-poisoned]

Update on "[PyTorch][Static Runtime] WIP: support memory planning for…

b1b0632

… to without requiring copying" Differential Revision: [D31776259](https://our.internmc.facebook.com/intern/diff/D31776259/) [ghstack-poisoned]

Update on "[PyTorch][Static Runtime] WIP: support memory planning for…

eb6796e

… to without requiring copying" Differential Revision: [D31776259](https://our.internmc.facebook.com/intern/diff/D31776259/) [ghstack-poisoned]

Update on "[PyTorch][Static Runtime] WIP: support memory planning for…

2f86bb5

… to without requiring copying" Differential Revision: [D31776259](https://our.internmc.facebook.com/intern/diff/D31776259/) [ghstack-poisoned]

Update on "[PyTorch][Static Runtime] WIP: support memory planning for…

c64185b

… to without requiring copying" Differential Revision: [D31776259](https://our.internmc.facebook.com/intern/diff/D31776259/) [ghstack-poisoned]

Update on "[PyTorch][Static Runtime] WIP: support memory planning for…

9027e48

… to without requiring copying" Differential Revision: [D31776259](https://our.internmc.facebook.com/intern/diff/D31776259/) [ghstack-poisoned]

Update on "[PyTorch][Static Runtime] WIP: support memory planning for…

e0ddaa9

… to without requiring copying" Differential Revision: [D31776259](https://our.internmc.facebook.com/intern/diff/D31776259/) [ghstack-poisoned]

Update on "[PyTorch][Static Runtime] WIP: support memory planning for…

e3a6455

… to without requiring copying" Differential Revision: [D31776259](https://our.internmc.facebook.com/intern/diff/D31776259/) [ghstack-poisoned]

This was referenced Dec 13, 2021

[PyTorch][SR][easy] s/input_or_constant_aliases/external_aliases/ #69852

Closed

[PyTorch][JIT] Support mayContainAlias(Value*, ArrayRef<Value*>) #69853

Closed

[PyTorch][JIT] use a better hash table in alias analysis #69854

Closed

swolchok added 10 commits December 13, 2021 11:58

Update on "[PyTorch][Static Runtime] WIP: support memory planning for…

380fbc8

… to without requiring copying" Differential Revision: [D31776259](https://our.internmc.facebook.com/intern/diff/D31776259/) [ghstack-poisoned]

Update on "[PyTorch][Static Runtime] WIP: support memory planning for…

5cf8a11

… to without requiring copying" Differential Revision: [D31776259](https://our.internmc.facebook.com/intern/diff/D31776259/) [ghstack-poisoned]

Update on "[PyTorch][Static Runtime] WIP: support memory planning for…

ec149c3

… to without requiring copying" Differential Revision: [D31776259](https://our.internmc.facebook.com/intern/diff/D31776259/) [ghstack-poisoned]

Update on "[PyTorch][Static Runtime] WIP: support memory planning for…

02c4ebf

… to without requiring copying" Differential Revision: [D31776259](https://our.internmc.facebook.com/intern/diff/D31776259/) [ghstack-poisoned]

Update on "[PyTorch][Static Runtime] WIP: support memory planning for…

b20fb18

… to without requiring copying" Differential Revision: [D31776259](https://our.internmc.facebook.com/intern/diff/D31776259/) [ghstack-poisoned]

Update on "[PyTorch][Static Runtime] WIP: support memory planning for…

fc53275

… to without requiring copying" Differential Revision: [D31776259](https://our.internmc.facebook.com/intern/diff/D31776259/) [ghstack-poisoned]

Update on "[PyTorch][Static Runtime] WIP: support memory planning for…

15eb33b

… to without requiring copying" Differential Revision: [D31776259](https://our.internmc.facebook.com/intern/diff/D31776259/) [ghstack-poisoned]

Update on "[PyTorch][Static Runtime] WIP: support memory planning for…

7deabd9

… to without requiring copying" Differential Revision: [D31776259](https://our.internmc.facebook.com/intern/diff/D31776259/) [ghstack-poisoned]

Update on "[PyTorch][Static Runtime] WIP: support memory planning for…

d93556b

… to without requiring copying" Differential Revision: [D31776259](https://our.internmc.facebook.com/intern/diff/D31776259/) [ghstack-poisoned]

Update on "[PyTorch][Static Runtime] WIP: support memory planning for…

9e9d020

… to without requiring copying" Differential Revision: [D31776259](https://our.internmc.facebook.com/intern/diff/D31776259/) [ghstack-poisoned]

swolchok changed the title ~~[PyTorch][Static Runtime] WIP: support memory planning for to without requiring copying~~ [PyTorch][Static Runtime] Support memory planning for to without requiring copying Jan 5, 2022

facebook-github-bot closed this in 4d8fc86 Jan 5, 2022

facebook-github-bot deleted the gh/swolchok/388/head branch January 8, 2022 15:17

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[PyTorch][Static Runtime] Support memory planning for to without requiring copying #67223

[PyTorch][Static Runtime] Support memory planning for to without requiring copying #67223

Uh oh!

swolchok commented Oct 25, 2021 •

edited

Loading

Uh oh!

pytorch-probot bot commented Oct 25, 2021 •

edited

Loading

⚛️ CI Flow

Uh oh!

facebook-github-bot commented Oct 25, 2021 •

edited

Loading

Uh oh!

eellison left a comment

Uh oh!

Uh oh!

[PyTorch][Static Runtime] Support memory planning for to without requiring copying #67223

[PyTorch][Static Runtime] Support memory planning for to without requiring copying #67223

Uh oh!

Conversation

swolchok commented Oct 25, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pytorch-probot bot commented Oct 25, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚛️ CI Flow

Uh oh!

facebook-github-bot commented Oct 25, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful links

💊 CI failures summary and remediations

🕵️ 1 new failure recognized by patterns

linux-xenial-py3.7-clang7-asan / test (default, 1, 3, linux.2xlarge) (1/1)

Uh oh!

eellison left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

swolchok commented Oct 25, 2021 •

edited

Loading

pytorch-probot bot commented Oct 25, 2021 •

edited

Loading

facebook-github-bot commented Oct 25, 2021 •

edited

Loading