Flake: diversify wrapper and package #173
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- seperated default.nix into two derrivations - default.nix hosting the wrapper and unwrapped.nix with original qs drv - passing non list argument to .withModules now displays an appropriate error message
|
time to fix CI nix code :woe: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
with the former implementation we were unable to call .overrideAttrs to
override the attributes of the underlying UNWRAPPED derivation (say
adding a postPatch)
With the current implementation, we may simply do so by calling
.override { quickshell-unwrapped = <qs-unwrapped with .overrideAttrs>; }
Tests Done
Todo