RA8x2 ethernet driver support #100995
Open
RA8x2 ethernet driver support #100995
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
December 14, 2025 07:26
Change hal_renesas revision to support ethernet for ra8x2 Signed-off-by: Nhat Ta <[email protected]>
This commit add entropy support for ra8x2. Signed-off-by: Nhat Ta <[email protected]>
This commit add ethernet driver support for ra8x2. Signed-off-by: Nhat Ta <[email protected]>
This commit put ethernet buffers and descriptors to nocache . Signed-off-by: Nhat Ta <[email protected]>
This commit add mdio driver support for ra8x2. Signed-off-by: Nhat Ta <[email protected]>
This commit define eswm module for ra8x2 that includes ethernet and mdio nodes. Signed-off-by: Nhat Ta <[email protected]>
This commit add phy driver support for Maxlinear GPY111. This driver implements vendor specific behaviour rgmii delay time setup, which is not present in the generic MII driver. Signed-off-by: Nhat Ta <[email protected]>
This commit add ethernet support for ek_ra8p1, ek_ra8m2, ek_ra8d2, mck_ra8t2. Signed-off-by: Nhat Ta <[email protected]>
duynguyenxa
changed the title
|
The following west manifest projects have changed revision in this Pull Request:
⛔ DNM label due to: 1 project with PR revision Note: This message is automatically posted and updated by the Manifest GitHub Action. |
github-actions
bot
added
manifest
manifest-hal_renesas
DNM (manifest)
|
jukkar
reviewed
Dec 14, 2025
Member
jukkar
left a comment
jukkar
left a comment
There was a problem hiding this comment.
Is the driver compile tested by the CI? If not, then I suggest you add the tests so that the code does not bit rot easily.
| struct eth_renesas_ra_data *data = dev->data; | ||
| fsp_err_t fsp_err = FSP_SUCCESS; | ||
|
|
||
| if (state->is_up) { |
Member
There was a problem hiding this comment.
I suggest following changes to avoid this "if() else" construct and extra indentation
if (!state->is_up) {
if (data->phy_link_up == 1) {
/* phy state change from up to down */
r_rmac_disable_reception(data->fsp_ctrl);
data->fsp_ctrl->link_establish_status = ETHER_LINK_ESTABLISH_STATUS_DOWN;
data->phy_link_up = 0;
LOG_DBG("link down");
net_eth_carrier_off(data->iface);
}
return;
}
data->fsp_ctrl->link_establish_status = ETHER_LINK_ESTABLISH_STATUS_UP;
data->phy_link_up = 1;
...
| #if defined(CONFIG_ETH_RENESAS_RA_USE_HW_WRITEBACK) | ||
| struct k_sem tx_sem; | ||
| #endif | ||
| uint8_t phy_link_up; |
Member
There was a problem hiding this comment.
This looks to be used as a boolean in the code, so why not have bool type?
| /* read again for remaining data */ | ||
| k_sem_give(&data->rx_sem); | ||
|
|
||
| pkt = net_pkt_rx_alloc_with_buffer(data->iface, (size_t)len, AF_UNSPEC, 0, K_MSEC(100)); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduce the support of Ethernet driver on RA8x2 devices base on eswm, rmac and rmac phy HWIP
This PR also add a new phy driver support for GPY111 chip