drivers: lora: ability to set custom sync word for LBM #101011
Conversation
Change way the sync word is set for LoraBasicModem so as to permit using a custom sync word/byte Modify samples in consequence, reduce default TX output for safety in case of mistake, set SF to something LLCC68 will accept. Signed-off-by: Camille BAUD <[email protected]>
|
zephyrbot
requested review from
JarmouniA,
JordanYates,
kartben,
martinjaeger,
mniestroj and
nashif
JordanYates
left a comment
JordanYates
left a comment
There was a problem hiding this comment.
I think this makes the transition from LoRaMAC node to LBM harder than it needs to be, while also making "standard" LBM usage more difficult. .public works fine for selecting between the two most common SYNC words, and changing the config struct for different backends makes user code (and samples) less ideal.
I actually already implemented this in my fork (Embeint@4b1678f), but was waiting for some other PRs to be merged before submitting it (#99884, #95362)
|
Well I considered implementing it exactly like in your code, but decided to go this way instead which made more sense to me. |
3 participants
Change way the sync word is set for LoraBasicModem so as to permit using a custom sync word/byte
Modify samples in consequence, reduce default TX output for safety in case of mistake, set SF default to something LLCC68 will accept.
Article about the sync word compatibility: https://blog.classycode.com/lora-sync-word-compatibility-between-sx127x-and-sx126x-460324d1787a
otherwise looked through lbm to see what it did with them as you would expect.
cross checked with 433mhz sx1278 and llcc68.