Uploaded image for project: 'Calcite'
  1. Calcite
  2. CALCITE-6585

In the Postgres TO_CHAR function, improve caching

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Closed
    • Major
    • Resolution: Fixed
    • None
    • 1.38.0
    • None

    Description

      In the Postgres TO_CHAR function (and similar functions added in CALCITE-6358), cache the formatter using the same technique used in CALCITE-5914.

      Also pass the DataContext into the constructor of class DataFormatFunction, so that it does not need to be passed to each call to toCharPg.

      In DateFormatFunction obsolete static field LOCAL_ZONE and instead populate a non-static field zoneId from the DataContext constructor parameter.

      Attachments

        Issue Links

          is related to

          Bug - A problem which impairs or prevents the functions of the product. CALCITE-5914 Cache compiled regular expressions in SQL function runtime

          • Major - Major loss of function.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. CALCITE-6775 ToChar and ToTimestamp PG implementors should use translator's root instead of creating a new root expression

          • Major - Major loss of function.
          • Closed
          relates to

          Bug - A problem which impairs or prevents the functions of the product. CALCITE-6596 Enable function-level cache by default

          • Major - Major loss of function.
          • Closed

          Improvement - An improvement or enhancement to an existing feature or task. CALCITE-6580 Remove Locale.setDefault

          • Major - Major loss of function.
          • Closed
          links to

          Web Link GitHub Pull Request #3978

          Activity

            People

              njordan Norman Jordan
              julianhyde Julian Hyde
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: