Uploaded image for project: 'Calcite'
  1. Calcite
  2. CALCITE-6867

Druid Adapter transforms an SQL NOT IN filter to a Druid IN filter

    XMLWordPrintableJSON

Details

    Description

      Currently Druid Adapter would transform in / not in to In filter which is not correct, need to fix it. 

      note:

      1. Currently DruidJsonFilter##toInKindDruidFilter had filter only handle for two kind SqlKind.DRUID_IN and SqlKind.DRUID_NOT_IN
      2. DruidJsonFilter##toInKindDruidFilter check for SqlKind.IN not SqlKind.DRUID_NOT_IN , would transform all to JsonInFilter include SqlKind.DRUID_NOT_IN , this is not fitable

      ut: DruidQueryFilterTest##testNotInFilter

      The newly added test fails as follows without the fix:

      Expected: with toString() "{\"type\":\"not\",\"field\":{\"type\":\"in\",\"dimension\":\"dimensionName\",\"values\":[\"1\",\"5\",\"value1\"]}}"
           but: toString() was "{\"type\":\"in\",\"dimension\":\"dimensionName\",\"values\":[\"1\",\"5\",\"value1\"]}" 

      Attachments

        Issue Links

          Activity

            People

              xuzifu666 Yu Xu
              xuzifu666 Yu Xu
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: