Uploaded image for project: 'Calcite'
  1. Calcite
  2. CALCITE-6895

Change JdbcTest.testVersion to strictly match minor version in gradle.properties

    XMLWordPrintableJSON

Details

    • Task
    • Status: Closed
    • Major
    • Resolution: Fixed
    • None
    • 1.40.0
    • None

    Description

      A recent bump of calcite.version to 1.40.0 broke JdbcTest.test version cause the following condition was no longer true.

          assertTrue(driverMinor >= 0 && driverMinor < 40);
      

      If we want to test that versions in properties really match those in JDBC it makes more sense to have strict equality instead of range. The drawback is that we have to update the test after every version bump.

      Attachments

        Issue Links

          Activity

            People

              zabetak Stamatis Zampetakis
              zabetak Stamatis Zampetakis
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: