daemon: Enable CDI by default #49963
Conversation
vvoland
added
status/2-code-review
kind/feature
|
Wondering if we should keep that ticket still open to consider working on the follow-ups (so "addresses / relates-to" instead of "fixes")? |
|
If this is enabled by default, I would expect |
|
Not 100% against, but also slightly concerned that we'd be overloading "docker info" even more ; we don't do the same currently for (e.g.) containerd runtimes. Given that these could be installed out of bound, I guess we can't memoize the results, so we'd have to re-read the list on every call to the /info endpoints; possibly parse each CDI spec we find to enumerate what's in them? |
No, https://github.com/moby/moby/blob/master/daemon/cdi.go#L63 by default does auto-refresh. |
|
Opened CDI device discovery as a separate PR (in case we decide to postpone it): #49980 |
|
Thanks both! Yes, probably it's fine to review / merge separately. As to my concerns about putting it in |
|
Any objections against merging it now, so we get this in rc1? @tonistiigi |
|
Needs a minor rebase after #49990 was merged |
|
Ok with getting this in but would like #49980 as well. |
|
Does this need another rebase to pass validation? It seems a vendor change around the same time as the rebase was pushed caused CI to fail. |
CDI will now be enabled by default unless opted-out by setting `cdi` feature to `false`. Signed-off-by: Paweł Gronowski <[email protected]>
|
I did a quick rebase |
|
All green; bringing this in |
Docker 28.2 no longer requires an explicit opt-in to use CDI: moby/moby#49963 Reflect that information in the README. Also, since the `--device` behavior is the same for both Docker and Podman, combine th This commit also combines the Docker and Podman section to share the `--device` option usage. Signed-off-by: Paweł Gronowski <[email protected]>
Docker 28.2 no longer requires an explicit opt-in to use CDI: moby/moby#49963 Reflect that information in the README. Also, since the `--device` behavior is the same for both Docker and Podman, combine them into one section. Signed-off-by: Paweł Gronowski <[email protected]>
CDI support has been available as opt-in starting from v25.0.0. Considering that there are no known blockers I believe it's about time to make it enabled by default to encourage wider usage.
- A picture of a cute animal (not mandatory but encouraged)