daemon: Discover devices and include in system info #49980
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vvoland
added
kind/feature
thaJeztah
reviewed
May 14, 2025
vvoland
force-pushed
the
devices-discovery
branch
from
b4cb42c to
aa737a3
Compare
tonistiigi
reviewed
May 14, 2025
thaJeztah
reviewed
May 14, 2025
vvoland
force-pushed
the
devices-discovery
branch
from
aa737a3 to
50d3900
Compare
vvoland
commented
May 14, 2025
api/types/system/info.go
Outdated
Comment on lines
169
to
171
| // Name is the unique identifier for the device. | ||
| // Example: CDI FQDN like "vendor.com/gpu=0", or other driver-specific device ID | ||
| Name string `json:"Name"` |
There was a problem hiding this comment.
Hmmm, on a second look, Name is probably too CDI-centric.
Perhaps ID would make more sense here to keep consistency with the actual DeviceRequest struct we use in our API.
moby/api/types/container/hostconfig.go
Line 263 in 2154b9c
@thaJeztah @tonistiigi WDYT?
There was a problem hiding this comment.
ok with calling it smth else. It should have the value that I can use in --device. Doesn't Source make more sense as Type?
There was a problem hiding this comment.
Source is the name of the device driver that discovered the device though. So that would be a cdi or nvidia. I think calling it Type would be more ambiguous?
thaJeztah
reviewed
May 15, 2025
vvoland
force-pushed
the
devices-discovery
branch
from
50d3900 to
08b40cb
Compare
|
Changed |
thaJeztah
reviewed
May 16, 2025
| @@ -3,7 +3,7 @@ package api // import "github.com/docker/docker/api" | |||
| // Common constants for daemon and client. | |||
| const ( | |||
| // DefaultVersion of the current REST API. | |||
| DefaultVersion = "1.49" | |||
| DefaultVersion = "1.50" | |||
thaJeztah
reviewed
May 16, 2025
thaJeztah
approved these changes
May 16, 2025
Logger was created but no consumed. Signed-off-by: Paweł Gronowski <[email protected]>
Prevent the daemon spawned for integration tests from sourcing the daemon configuration intended interactive dev shell usage. Before this change, integration tests would fail to create a daemon with different configuration provided via cli flags (like `--feature`) if they're already specified in the default daemon.json. Signed-off-by: Paweł Gronowski <[email protected]>
Signed-off-by: Paweł Gronowski <[email protected]>
Add ability for the device driver to implement a device discovery mechanism and expose discovered devices in the `docker info` output. Currently it's only implemented for CDI devices. Signed-off-by: Paweł Gronowski <[email protected]>
Signed-off-by: Paweł Gronowski <[email protected]>
vvoland
force-pushed
the
devices-discovery
branch
from
08b40cb to
c1b2be0
Compare
dmcgowan
approved these changes
May 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add ability for the device driver to implement a device discovery mechanism and expose discovered devices in the
docker infooutput.Currently it's only implemented for CDI devices.
- How to verify it
New tests
Example
/infooutput:- Human readable description for the release notes
TODO: Make CLI print it (
docker infonow returnsDiscoveredDevicesproviding a result of CDI device discovery.)